build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48504 ) Change subject: arch/x86/car.ld: Align the stack at buildtime ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/c/coreboot/+/48504/1/src/include/memlayout.h File src/include/memlayout.h: https://review.coreboot.org/c/coreboot/+/48504/1/src/include/memlayout.h@63 PS1, Line 63: #define CAR_STACK(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop https://review.coreboot.org/c/coreboot/+/48504/1/src/include/memlayout.h@63 PS1, Line 63: #define CAR_STACK(addr, size) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/48504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4abf58619e4a09563451683960918c8794f186dc Gerrit-Change-Number: 48504 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 09 Dec 2020 13:29:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment