Patch set 1:Code-Review +1
3 comments:
Patch Set #1, Line 7: PBET timer
nit: this is saying "Protect BIOS Environment Timer timer"
File src/cpu/x86/16bit/entry16.inc:
Patch Set #1, Line 32: #define BOOTGUARD_PBEC 0x139
I'd order the MSR definitions in numerically increasing order (0x139 < 0x13a)
Patch Set #1, Line 129: wrmsr
I wonder if you really need to do this in assembly.
As coreboot may take an arbitrarily long time to execute (because debugging stuff and the like), it's better to do this really early.
To view, visit change 43395. To unsubscribe, or for help writing mail filters, visit settings.