Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44239 ) Change subject: cpu/intel/model_6xx: Update ucode before enabling cache ...................................................................... Patch Set 4: (1 comment) Keith, could you please boot-test this change? https://review.coreboot.org/c/coreboot/+/44239/4/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c: https://review.coreboot.org/c/coreboot/+/44239/4/src/cpu/intel/model_6xx/mod... PS4, Line 13: intel_update_microcode_from_cbfs();
is this tested ? That's why I added Keith as a reviewer.
-- To view, visit https://review.coreboot.org/c/coreboot/+/44239 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f197cc8cf10eac2815961043e8c343aa3c204d Gerrit-Change-Number: 44239 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 07 Aug 2020 10:01:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment