Angel Pons has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/46915?usp=email ) Change subject: cpu/intel/haswell: Clean up CPUID definitions ...................................................................... Patch Set 17: (3 comments) File src/cpu/intel/haswell/haswell.h: https://review.coreboot.org/c/coreboot/+/46915/comment/fee4b138_7b583d83?usp... : PS17, Line 11: 0x306c0
Oof: […] CB:91625
https://review.coreboot.org/c/coreboot/+/46915/comment/036304af_1f5906f4?usp... : PS17, Line 12: #define BROADWELL_FAMILY_ULT 0x306d0
```suggestion […]
CB:91625 https://review.coreboot.org/c/coreboot/+/46915/comment/91e5545d_abf62058?usp... : PS17, Line 27: #define CPUID_BROADWELL_C0 0x40671
```suggestion […]
CB:91625 -- To view, visit https://review.coreboot.org/c/coreboot/+/46915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19e56b8826b1514550ae95e6363b0df2d08e3cb7 Gerrit-Change-Number: 46915 Gerrit-PatchSet: 17 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <patrick@coreboot.org> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Tue, 14 Apr 2026 16:02:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>