We have some bigger plans around this topic, the -2 is to get the discussion done first so we do not go back-and-forth with this specific header.

This is technically correct, but I would disagree on having PCI_SLOT() and PCI_DEVFN() et.al. defined in <device/pci_def.h>. IMHO that file should be strictly about definitions dictated by the various PCI standard papers.

Patch set 1:Code-Review -2

View Change

To view, visit change 37842. To unsubscribe, or for help writing mail filters, visit settings.