Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39035 ) Change subject: mainboard/google/octopus: Migrate onto SKU ID helpers ...................................................................... Patch Set 11: (2 comments) https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... File src/mainboard/google/octopus/Makefile.inc: https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... PS11, Line 13: smm-y += mainboard_misc.c
Yes, it is used to identify the SKUs which have LTE so that in those SKUs we can toggle few GPIOs to […] Done
https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... File src/mainboard/google/octopus/mainboard_misc.c: https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... PS11, Line 24: const char *smbios_system_sku(void)
Nit: This function can be put back into mainboard.c and this file removed. […] This is already handled in a follow up where we plan to collapse all these wrapping strong symbols down into a single strong symbol from src/ec/google/chromeec/ec_skuid.{o}.
-- To view, visit https://review.coreboot.org/c/coreboot/+/39035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60a37a5f9659b8df4018872956f95e07a3506440 Gerrit-Change-Number: 39035 Gerrit-PatchSet: 11 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Jett Rink <jettrink@chromium.org> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 04 Mar 2020 02:06:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jett Rink <jettrink@chromium.org> Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com> Gerrit-MessageType: comment