Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38989 ) Change subject: Kconfig,Makefile.inc: Add support for link time optimization ...................................................................... Patch Set 8: (5 comments) https://review.coreboot.org/c/coreboot/+/38989/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38989/2//COMMIT_MSG@23 PS2, Line 23: the Thinkpad T500, and both targets boot successfully.
For the T500 it's ~8ms less, but otherwise about the same. […] Done
https://review.coreboot.org/c/coreboot/+/38989/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38989/3//COMMIT_MSG@14 PS3, Line 14: - The dead_code() macro causes linking errors, since dead functions
I recall having some problems with it early on, but I can't reproduce them anymore. […] Done
https://review.coreboot.org/c/coreboot/+/38989/2/src/Kconfig File src/Kconfig: https://review.coreboot.org/c/coreboot/+/38989/2/src/Kconfig@123 PS2, Line 123: depends on COMPILER_GCC
I am able to successfully build and boot QEMU i440fx with LLVM/Clang. Done
https://review.coreboot.org/c/coreboot/+/38989/4/src/Kconfig File src/Kconfig: https://review.coreboot.org/c/coreboot/+/38989/4/src/Kconfig@120 PS4, Line 120: bool "Use link time optimization"
Also add *(LTO)* at the end. Done
https://review.coreboot.org/c/coreboot/+/38989/4/src/Kconfig@122 PS4, Line 122: default y
Could you split `default y` out to a separate commit please on top. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/38989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48c31ea8b1b57276125cffdac44c7c16642547ac Gerrit-Change-Number: 38989 Gerrit-PatchSet: 8 Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca> Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Keith Hui <buurin@gmail.com> Gerrit-Comment-Date: Tue, 28 Apr 2020 23:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Comment-In-Reply-To: Jacob Garber <jgarber1@ualberta.ca> Gerrit-MessageType: comment