Kacper Słomiński has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 ) Change subject: mainboard/samsung/350v5c: add initial board files and Kconfig option for 6 MB flash ...................................................................... Patch Set 8:
Patch Set 8:
(1 comment)
The board has 2 ROM chips, a 4 MB one and a 2 MB one. Both are connected to the PCH and their contents get treated as one big ROM. The 4 MB one contains the IFD(4 KB), ME(approx 1.4 MB) and beginning of the BIOS region(all remaining space). The 2 MB one contains the rest of the BIOS region. autoport generated the board Kconfig with info about a 6 MB ROM and I just added the definitions to this file. If you have a better suggestion as to what I should do in this case, please tell me and I'll do that instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/30942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843 Gerrit-Change-Number: 30942 Gerrit-PatchSet: 8 Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 17 Jan 2019 19:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment