Attention is currently required from: Arthur Heymans, Arthur Heymans, ron minnich. Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email ) Change subject: riscv/mb/qemu: fix DRAM probing ...................................................................... Patch Set 9: (3 comments) File src/arch/riscv/ramdetect.c: https://review.coreboot.org/c/coreboot/+/36486/comment/8adfa408_a6320919 : PS9, Line 21: #define insn_size 4
Is this true in an era of compact instruction extension? I no longer know. […] we can't. to be really sure we'd have to read the instruction from memory. so this is a hack that works as long as we have 4 byte instructions.
https://review.coreboot.org/c/coreboot/+/36486/comment/07dcef89_da93a493 : PS9, Line 29: */
Can we ensure we never build with compact instrutions enabled? I'd be fine with that. see above.
https://review.coreboot.org/c/coreboot/+/36486/comment/d22342f7_1cc2e61b : PS9, Line 35: uintptr_t addr = dram_start + (size * MiB) - sizeof(uint32_t);
Should we make sure dram_start is 32-bit aligned, in case of someone doing something silly? it would […] dram_start is coming from the linker file and we assume that memory is usually aligned, if not I'd rather have an exception during probing, I think.
-- To view, visit https://review.coreboot.org/c/coreboot/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25860f688c7546714f6fdbce8c8f96da6400813c Gerrit-Change-Number: 36486 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Marc Karasek <marckarasek@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-CC: ron minnich Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: ron minnich Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Sun, 04 Feb 2024 00:26:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ron minnich Gerrit-MessageType: comment