Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39035 ) Change subject: mainboard/google/octopus: Migrate onto SKU ID helpers ...................................................................... Patch Set 11: Furquan, please note the usage of the symbol in smm here due to differentiation on sku for radios. -- To view, visit https://review.coreboot.org/c/coreboot/+/39035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60a37a5f9659b8df4018872956f95e07a3506440 Gerrit-Change-Number: 39035 Gerrit-PatchSet: 11 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Jett Rink <jettrink@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 27 Feb 2020 08:34:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment