Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44241 ) Change subject: cpu/intel/model_6xx: Unify all Slot 1 CPUs ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/44241/4/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c: https://review.coreboot.org/c/coreboot/+/44241/4/src/cpu/intel/model_6xx/mod... PS4, Line 26: if ((dev->device & 0x0ff0) == 0x0680 || (dev->device & 0x0ff0) == 0x06b0) { : char processor_name[49]; : : fill_processor_name(processor_name); : printk(BIOS_INFO, "CPU: %s.\n", processor_name); : } I don't think it makes sense to print the processor name on just these CPU's. One could just check in fill_processor_name() if CPUID.EAX=0x80000004 is supported and change the return type to report fail/success. -- To view, visit https://review.coreboot.org/c/coreboot/+/44241 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22092d97c244263eec7e65abbfe2bbeb58680fc8 Gerrit-Change-Number: 44241 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment