Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 ) Change subject: Documentation: Add guidelines for new mainboard ports ...................................................................... Patch Set 6: (8 comments) https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... File Documentation/getting_started/new_mainboard_ports.md: https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 3: mainboards
singular 'mainboard' Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 7: It provides
"It generally provides"? For example the AMD Picasso code won't be getting SPDs since memory is alr […] Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 16: Try to find out as much as possible about the current hardware. : Dump information with existing tools: : * lspci : * lsusb : * superiotool : * inteltool : * ectool : * dmidecode : * acpidump
Maybe "guard" this with an "if you are retrofitting coreboot to a mainboard which already has a work […] Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 45: 5. Be able to recover from a bad flash. You should use external flashing as : it's likely that you will brick your platform on the first attempts. : Make sure to backup the original firmware (if any).
IMHO, this should be the first thing. […] Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 53: scheme instead.
I would prefer to tell somebody to use the variants mechanism, than to have them undo the variants b […] Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 54: logical
should be an adverb: logically Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 56: Provide good documentation, see point 4
Maybe "Provide good documentation when possible. […] Done
https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 74: You must own the Copyright
Thank you. Maybe: […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I134dbf2341696ba0dd33c3d52bf787b8eaabbdab Gerrit-Change-Number: 34632 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 11 Mar 2020 18:15:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth@google.com> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment