Attention is currently required from: Anil Kumar K, Paul Menzel, Andrey Petrov, Patrick Rudolph.

View Change

1 comment:

• File src/drivers/intel/fsp2_0/hand_off_block.c:

  • Patch Set #17, Line 316:

    	if (CONFIG(PLATFORM_USES_FSP2_3)) {
    		union {
    			const struct fsp_nvs_hob2_data_region_header *hob;
    			const void *hob_descr;
    		} hob_walker;
    		hob_walker.hob = (const struct fsp_nvs_hob2_data_region_header *)
    				fsp_find_extension_hob_by_guid(fsp_nv_storage_guid_2, size);
    		if (hob_walker.hob != NULL) {
    			*size = hob_walker.hob->nvs_data_length;
    			return hob_walker.hob_descr;
    		}
    	} else {
    		return fsp_find_extension_hob_by_guid(fsp_nv_storage_guid, size);
    	}
    

    I might return early just to avoid an extra indent, e.g.:

    ```
    if (!CONFIG(PLATFORM_USES_FSP2_3))
    	return fsp_find_extension_hob_by_guid(fsp_nv_storage_guid, size);

    union {
    	const struct fsp_nvs_hob2_data_region_header *hob;
    	const void *hob_descr;
    } hob_walker;
    hob_walker.hob = (const struct fsp_nvs_hob2_data_region_header *)
    		fsp_find_extension_hob_by_guid(fsp_nv_storage_guid_2, size);

    if (hob_walker.hob != NULL) {
    	*size = hob_walker.hob->nvs_data_length;
    	return hob_walker.hob_descr;
    }

    return NULL;
    ```

To view, visit change 59638. To unsubscribe, or for help writing mail filters, visit settings.