- coreboot-gerrit - mail.coreboot.org

[XS] Change in coreboot[main]: mb/starlabs/adl: Use updated Realtek speaker coef
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/94075?usp=email ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/adl: Use updated Realtek speaker coef ...................................................................... mb/starlabs/adl: Use updated Realtek speaker coef Use Realtek's updated ALC269 coefficient 0x0c value of 0x3f00 for Horizon to enable speaker output. TEST=adl_horizon: Flashed the updated coefficient and confirmed speaker output. TEST=adl_horizon_1334u: Flashed the updated coefficient and confirmed speaker output. Change-Id: Ia742554c397a0ae7b23111442be33197f8de038f Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/94075 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/adl/variants/hz/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/adl/variants/hz/hda_verb.c b/src/mainboard/starlabs/adl/variants/hz/hda_verb.c index 73ccd59..813c0f0 100644 --- a/src/mainboard/starlabs/adl/variants/hz/hda_verb.c +++ b/src/mainboard/starlabs/adl/variants/hz/hda_verb.c @@ -78,7 +78,7 @@ 0x02050008, 0x02040000, 0x0205000c, - 0x02044b00, + 0x02043f00, /* ALC269 Default 4 */ 0x02050015, 0x02048002, -- To view, visit https://review.coreboot.org/c/coreboot/+/94075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia742554c397a0ae7b23111442be33197f8de038f Gerrit-Change-Number: 94075 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/adl: Use updated Realtek speaker coef
by Sean Rhodes (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/94075?usp=email ) Change subject: mb/starlabs/adl: Use updated Realtek speaker coef ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/94075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia742554c397a0ae7b23111442be33197f8de038f Gerrit-Change-Number: 94075 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 20:31:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/asus/[p8z77-v_le_plus,p8h77-v]: Add common COM A Kconfig hint
by Keith Hui (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Angel Pons, Matt DeVillier. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/89086?usp=email ) Change subject: mb/asus/[p8z77-v_le_plus,p8h77-v]: Add common COM A Kconfig hint ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/89086/comment/4fbdc3ae_f831c617?us… : PS7, Line 9: They > 'they is a bit vague'. These two boards? […] The next patch in the series will have restructured early inits that goes like this: bootblock_mainboard_early_init(): Enable serial port for bootblock console only. This is being unified. bootblock_mainboard_init(): Variant specific early init, such as SIO pins setup that are currently done in _early_init. Because these will be moved after serial port init, the hint for nuvoton_enable_serial() to configure serial port A pins properly and for bootblock console to still work. I also found two other existing romstage hooks that sits barely used so I'm moving all the DRAM_LED stuff there: platform_romstage_pre_mem(): Turns on DRAM_LED and try to influence raminit with successively more conservative timings. platform_romstage_post_mem(): Turns off DRAM_LED and take MemOK stuff offline. This hook getting control means raminit succeeded. Having said this, I should just apply this to the entire series, marking separately boards that don't have serial port at all. Expect another patchset soon. -- To view, visit https://review.coreboot.org/c/coreboot/+/89086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64226db1d77e5291fcb4ebfd0b35dc4d3c03b5ed Gerrit-Change-Number: 89086 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 19:29:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: sb/intel/bd82x6x: Add PCH soft strap 9 reflashing support
by Angel Pons (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Intel coreboot Reviewers, Keith Hui. Angel Pons has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/93645?usp=email ) Change subject: sb/intel/bd82x6x: Add PCH soft strap 9 reflashing support ...................................................................... Patch Set 1: (1 comment) File src/southbridge/intel/bd82x6x/ifd.c: https://review.coreboot.org/c/coreboot/+/93645/comment/0234d21a_6157c831?us… : PS1, Line 17: enum cb_err pch_reprogram_pciepcs(u8 pciepcs) Would it make sense to make this more general (e.g. able to update any PCHSTRP at the very least)? -- To view, visit https://review.coreboot.org/c/coreboot/+/93645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib19b9f6410f68178f1f68bf7ca8efbb757a92480 Gerrit-Change-Number: 93645 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 17:39:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: lib/bootmode: Allow to set the boot mode at runtime
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Kapil Porwal, Patrick Rudolph, Subrata Banik. Matt DeVillier has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/94095?usp=email ) Change subject: lib/bootmode: Allow to set the boot mode at runtime ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/94095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0809af2de05bbf1078e39f4d9fa208c9ae309738 Gerrit-Change-Number: 94095 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 16:51:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: lib/coreboot_table: Always pass the boot mode to the payload
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Angel Pons, Jakub "Kuba" Czapiga, Kapil Porwal, Patrick Rudolph, Subrata Banik. Matt DeVillier has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/94094?usp=email ) Change subject: lib/coreboot_table: Always pass the boot mode to the payload ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/94094?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib1aa39139f72b19ec180fb7cd43afbad52b3b6a2 Gerrit-Change-Number: 94094 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 16:50:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: drivers/efi/capsules: Fix driver on x86_64
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Angel Pons, Michał Żygowski, Patrick Rudolph. Matt DeVillier has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/94091?usp=email ) Change subject: drivers/efi/capsules: Fix driver on x86_64 ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File src/drivers/efi/capsules.c: https://review.coreboot.org/c/coreboot/+/94091/comment/c41061e4_581392f4?us… : PS4, Line 177: block->len = len ? *len : 0; : : volatile uint64_t *addr = map_range(block->self + sizeof(uint64_t), sizeof(uint64_t)); : block->addr = addr ? *addr : 0; : } : : static void store_block(const struct block_descr *block) : { : volatile uint64_t *len = map_range(block->self, sizeof(uint64_t)); : if (len) : *len = block->len; : : volatile uint64_t *addr = map_range(block->self + sizeof(uint64_t), sizeof(uint64_t)); : if (addr) : *addr = block->addr; : } these related to the change at hand, or just cleanup? https://review.coreboot.org/c/coreboot/+/94091/comment/cd6d585b_f6eadbd8?us… : PS4, Line 354: if (!capsule_hdr || !is_good_capsule(capsule_hdr)) { same here -- To view, visit https://review.coreboot.org/c/coreboot/+/94091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2068cbb3d7f42c6b957a6693f2891475e60ac603 Gerrit-Change-Number: 94091 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 16:49:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: ec/starlabs/merlin: Generate EC device with acpigen
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/94157?usp=email ) Change subject: ec/starlabs/merlin: Generate EC device with acpigen ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/94157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia1a379fbe8d245d55ba3103f76aabcb6a08b8da0 Gerrit-Change-Number: 94157 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sat, 18 Jul 2026 16:48:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: ec/starlabs/merlin: Generate query events with acpigen
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/94156?usp=email ) Change subject: ec/starlabs/merlin: Generate query events with acpigen ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/94156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic303a5188adbfa8425dfca778ee98cf67f12269d Gerrit-Change-Number: 94156 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sat, 18 Jul 2026 16:48:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: ec/starlabs/merlin: Generate sleep hooks with acpigen
by Matt DeVillier (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/94155?usp=email ) Change subject: ec/starlabs/merlin: Generate sleep hooks with acpigen ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/94155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4fb69c0ce3679069e5fbf8d91ad0fcaeea7b6c30 Gerrit-Change-Number: 94155 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sat, 18 Jul 2026 16:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0