October 2026 - coreboot-gerrit

[M] Change in coreboot[main]: soc/amd/common/acpi/lpc: Disable legacy IRQs for HPET
by Sean Rhodes (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Felix Held, Michał Żygowski, Patrick Rudolph. Sean Rhodes has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/93980?usp=email ) Change subject: soc/amd/common/acpi/lpc: Disable legacy IRQs for HPET ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/93980/comment/b8928e92_17a6c772?us… : PS1, Line 16: Hwoever > typo; should be 'However' Done File src/soc/amd/common/acpi/lpc.asl: https://review.coreboot.org/c/coreboot/+/93980/comment/b7ad737b_3ee5bfd2?us… : PS1, Line 63: IRQ(Edge, ActiveHigh, Shared){8} > should some comment about this be added to point out that this still works, since the hpet won't gen […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/93980?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a5a6874be5b14dc1f2495e507768f21bfbd6f69 Gerrit-Change-Number: 93980 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 20:38:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[M] Change in coreboot[main]: soc/amd/common/acpi/lpc: Disable legacy IRQs for HPET
by Sean Rhodes (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Felix Held, Michał Żygowski, Patrick Rudolph. Sean Rhodes has uploaded a new patch set (#2) to the change originally created by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/93980?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Felix Held, Verified+1 by build bot (Jenkins) Change subject: soc/amd/common/acpi/lpc: Disable legacy IRQs for HPET ...................................................................... soc/amd/common/acpi/lpc: Disable legacy IRQs for HPET When HPET is enabled, the common AMD ACPI code omits the RTC IRQ to avoid a resource conflict with HPET. This prevents Linux rtcwake from working, as observed in CB:93459. Clear HPET legacy replacement mode during firmware initialization and always advertise IRQ8 for RTC and IRQ0 for the timer. MSI capability remains enabled; clearing legacy replacement does not force MSI-only operation. The OS can subsequently enable legacy replacement mode. Report HPET's legacy IRQ resources only when legacy replacement is enabled. Explain why firmware initially leaves these IRQs to RTC and the timer; shared resource descriptors do not make independent edge-triggered interrupt sources safe to use simultaneously. TEST=Use rtcwake to power on the Gigabyte MZ33-AR1 after a poweroff in Ubuntu. Check Windows Device Manager does not have resource conflicts in RTC device. Change-Id: I3a5a6874be5b14dc1f2495e507768f21bfbd6f69 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/amd/common/acpi/lpc.asl M src/soc/amd/common/block/acpimmio/mmio_util.c M src/soc/amd/common/block/include/amdblocks/acpimmio.h 3 files changed, 50 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/93980/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/93980?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a5a6874be5b14dc1f2495e507768f21bfbd6f69 Gerrit-Change-Number: 93980 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: mb/hp: Convert prodesk_600_g1_sff into a variant
by Alexis Calin (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Nicholas Chin, Walter Sonius. Alexis Calin has posted comments on this change by Alexis Calin. ( https://review.coreboot.org/c/coreboot/+/96015?usp=email ) Change subject: mb/hp: Convert prodesk_600_g1_sff into a variant ...................................................................... Patch Set 6: (3 comments) Patchset: PS5: > I wouldn't really expect any functional changes from what I see in this change, so I'm fine if it do […] I tried to get a timeless hash, but I didn't managed. Also since the base is meant for every haswell hp desktops, I think the minimal variant is actually counter productive in this case since it will have to changed to accommodate boards with differents files. PS5: > Rebasing onto the latest main should fix the build bot issue. […] Just rebased and applied the change of commit you recommended, thank you very much for your input. Commit Message: https://review.coreboot.org/c/coreboot/+/96015/comment/e446b6e0_a436030a?us… : PS5, Line 7: mb/hp/haswell_desktops: Convert prodesk_600_g1_sff in haswell_desktops base variant > Maybe […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/96015?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff85712da1d9930653d132a33e2daa3590d90cb3 Gerrit-Change-Number: 96015 Gerrit-PatchSet: 6 Gerrit-Owner: Alexis Calin Gerrit-Reviewer: Alexis Calin Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 20:17:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Comment-In-Reply-To: Walter Sonius <walterav1984(a)gmail.com> Comment-In-Reply-To: Alexis Calin

1 0

[S] Change in coreboot[main]: mb/hp: Convert prodesk_600_g1_sff into a variant
by Alexis Calin (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Alexis Calin, Walter Sonius. Hello Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/96015?usp=email to look at the new patch set (#6). Change subject: mb/hp: Convert prodesk_600_g1_sff into a variant ...................................................................... mb/hp: Convert prodesk_600_g1_sff into a variant In preparation for adding other similar HP desktops, convert the Prodesk 600 G1 SFF port to a variant scheme. Change-Id: Iff85712da1d9930653d132a33e2daa3590d90cb3 Signed-off-by: Alexis Calin <alexis_calin(a)yahoo.fr> --- R src/mainboard/hp/haswell_desktops/Kconfig R src/mainboard/hp/haswell_desktops/Kconfig.name A src/mainboard/hp/haswell_desktops/Makefile.mk R src/mainboard/hp/haswell_desktops/acpi/ec.asl R src/mainboard/hp/haswell_desktops/acpi/platform.asl R src/mainboard/hp/haswell_desktops/acpi/superio.asl A src/mainboard/hp/haswell_desktops/board_info.txt R src/mainboard/hp/haswell_desktops/bootblock.c R src/mainboard/hp/haswell_desktops/cmos.default R src/mainboard/hp/haswell_desktops/cmos.layout R src/mainboard/hp/haswell_desktops/devicetree.cb R src/mainboard/hp/haswell_desktops/dsdt.asl R src/mainboard/hp/haswell_desktops/gma-mainboard.ads R src/mainboard/hp/haswell_desktops/romstage.c R src/mainboard/hp/haswell_desktops/variants/prodesk_600_g1_sff/board_info.txt R src/mainboard/hp/haswell_desktops/variants/prodesk_600_g1_sff/data.vbt R src/mainboard/hp/haswell_desktops/variants/prodesk_600_g1_sff/gpio.c R src/mainboard/hp/haswell_desktops/variants/prodesk_600_g1_sff/hda_verb.c A src/mainboard/hp/haswell_desktops/variants/prodesk_600_g1_sff/overridetree.cb D src/mainboard/hp/prodesk_600_g1_sff/Makefile.mk 20 files changed, 33 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/96015/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/96015?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff85712da1d9930653d132a33e2daa3590d90cb3 Gerrit-Change-Number: 96015 Gerrit-PatchSet: 6 Gerrit-Owner: Alexis Calin Gerrit-Reviewer: Alexis Calin Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Attention: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Attention: Alexis Calin

1 0

[M] Change in coreboot[main]: payloads/external/LinuxBoot: Add a kernel config for Mediatek based C...
by Michał Kopeć (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Alicja Michalska, Christian Walter, Ingo Reitz, Martin L Roth. Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/95860?usp=email ) Change subject: payloads/external/LinuxBoot: Add a kernel config for Mediatek based Chromebooks ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Updated: Added ISO9660 and USB drivers so that booting USB media is possible. -- To view, visit https://review.coreboot.org/c/coreboot/+/95860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I209537c669af91150befa7dbedb34ad20b767225 Gerrit-Change-Number: 95860 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 19:22:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: payloads/external/LinuxBoot: Add a kernel config for Mediatek based C...
by Michał Kopeć (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Alicja Michalska, Christian Walter, Ingo Reitz, Martin L Roth, Michał Kopeć. Hello Alicja Michalska, Christian Walter, Ingo Reitz, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/95860?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Ingo Reitz, Verified+1 by build bot (Jenkins) Change subject: payloads/external/LinuxBoot: Add a kernel config for Mediatek based Chromebooks ...................................................................... payloads/external/LinuxBoot: Add a kernel config for Mediatek based Chromebooks Add a Linux 7.2 defconfig for a LinuxBoot payload on Mediatek-based Chromebook platforms. TEST=Build google/ciri and boot to Debian forky. Display and keyboard are working correctly in LinuxBoot. Change-Id: I209537c669af91150befa7dbedb34ad20b767225 Signed-off-by: Michał Kopeć <michal(a)nozomi.space> --- A payloads/external/LinuxBoot/arm64/defconfig-mediatek 1 file changed, 181 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/95860/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/95860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I209537c669af91150befa7dbedb34ad20b767225 Gerrit-Change-Number: 95860 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/bluey: Select FW_CONFIG and override for all variants
by Kapil Porwal (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Julius Werner, Karthik Ramasubramanian, Subrata Banik, Yu-Ping Wu. Kapil Porwal has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/96037?usp=email ) Change subject: mb/google/bluey: Select FW_CONFIG and override for all variants ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/96037?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icef0e607e994fbf9f4d7c8cb01567d0a6a6a6964 Gerrit-Change-Number: 96037 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 18:48:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/{bluey,calypso}: Add CDT fw_config fields
by Kapil Porwal (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Julius Werner, Karthik Ramasubramanian, Subrata Banik, Yu-Ping Wu. Kapil Porwal has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/95921?usp=email ) Change subject: mb/google/{bluey,calypso}: Add CDT fw_config fields ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/95921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id94e1ed59472bdd42f3cc231f57681dc6a6a6964 Gerrit-Change-Number: 95921 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 18:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/baytrail: Implement TA 556192 USB2 PHY workaround
by Angel Pons (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier. Angel Pons has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/96065?usp=email ) Change subject: soc/intel/baytrail: Implement TA 556192 USB2 PHY workaround ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/96065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib52069941cd2543eb8fcc74d6a0cdd3f2c4734ef Gerrit-Change-Number: 96065 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 18:02:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: sb/intel/lynxpoint: Use Wildcat Point Serial IO DMA request lines
by Angel Pons (Code Review) Oct. 6, 2026

Oct. 6, 2026

Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier. Angel Pons has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/96075?usp=email ) Change subject: sb/intel/lynxpoint: Use Wildcat Point Serial IO DMA request lines ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/96075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3081c74b169f902b93daeff89f3adfef70fc2e7f Gerrit-Change-Number: 96075 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Comment-Date: Tue, 06 Oct 2026 18:01:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0