August 2025 - coreboot-gerrit - mail.coreboot.org

[XS] Change in coreboot[main]: drivers/soundwire/alc711: Support clock stop flag from devicetree
by Simon Yang (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Ian Feng, Jayvik Desai, Kapil Porwal, Mac Chiang, Pranava Y N, Shumingf -, Subrata Banik. Simon Yang has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/88586?usp=email ) Change subject: drivers/soundwire/alc711: Support clock stop flag from devicetree ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/88586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If958cd0c2136e4dd3f60cb9203d9394913d3f66e Gerrit-Change-Number: 88586 Gerrit-PatchSet: 12 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 02:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support
by Mac Chiang (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Ian Feng, Jayvik Desai, Kapil Porwal, Mac Chiang, Pranava Y N, Shumingf -, Subrata Banik. Mac Chiang has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/88587?usp=email ) Change subject: mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/88587?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I975ed83e8614bd88861f115ffeea7c2450e6a432 Gerrit-Change-Number: 88587 Gerrit-PatchSet: 17 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 02:05:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/soundwire/alc711: Support clock stop flag from devicetree
by Mac Chiang (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Ian Feng, Jayvik Desai, Kapil Porwal, Mac Chiang, Pranava Y N, Shumingf -, Simon Yang, Subrata Banik. Mac Chiang has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/88586?usp=email ) Change subject: drivers/soundwire/alc711: Support clock stop flag from devicetree ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/88586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If958cd0c2136e4dd3f60cb9203d9394913d3f66e Gerrit-Change-Number: 88586 Gerrit-PatchSet: 12 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 02:05:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support
by Ian Feng (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Ian Feng, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Subrata Banik. Hello Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/88587?usp=email to look at the new patch set (#17). Change subject: mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support ...................................................................... mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support This change allows flag to be override via devicetree, instead of relying on the default value in alc711_slave. It helps fix the missing event issue when plugging or unplugging the 3.5mm headphone jack. BUG=b:417133565, b:420516709 TEST=Verified build and boot with ALC721 and ALC722. Headphone path switches successfully via audio jack event. Confirmed SSDT dump at PCI0.HDAS.SNDW. Package (0x02) { "mipi-sdw-simplified-clockstopprepare-sm-supported", Zero }, Change-Id: I975ed83e8614bd88861f115ffeea7c2450e6a432 Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> --- M src/mainboard/google/fatcat/variants/francka/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/88587/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/88587?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I975ed83e8614bd88861f115ffeea7c2450e6a432 Gerrit-Change-Number: 88587 Gerrit-PatchSet: 17 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: drivers/soundwire/alc711: Support clock stop flag from devicetree
by Ian Feng (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Simon Yang, Subrata Banik. Ian Feng has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/88586?usp=email ) Change subject: drivers/soundwire/alc711: Support clock stop flag from devicetree ...................................................................... Patch Set 12: (1 comment) File src/drivers/soundwire/alc711/alc711.c: https://review.coreboot.org/c/coreboot/+/88586/comment/bd44a193_06141e6a?us… : PS11, Line 135: alc711_slave.simplified_clockstopprepare_sm_supported = true; > I'll try it out. I tested removing it, and confirmed that it has no impact. -- To view, visit https://review.coreboot.org/c/coreboot/+/88586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If958cd0c2136e4dd3f60cb9203d9394913d3f66e Gerrit-Change-Number: 88586 Gerrit-PatchSet: 12 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 01:52:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com>

1 0

[XS] Change in coreboot[main]: drivers/soundwire/alc711: Support clock stop flag from devicetree
by Ian Feng (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Simon Yang, Subrata Banik. Hello Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Simon Yang, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/88586?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Code-Review+1 by Mac Chiang, Code-Review+1 by Simon Yang, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: drivers/soundwire/alc711: Support clock stop flag from devicetree ...................................................................... drivers/soundwire/alc711: Support clock stop flag from devicetree Allow overriding the default value (true) via devicetree configuration. If disable_clkstop_sm_support is set in the devicetree, the corresponding field in alc711_slave is set to false. BUG=b:417133565, b:420516709 TEST=Verified build and boot with ALC721 and ALC722. Headphone path switches successfully via audio jack event. Confirmed SSDT dump at PCI0.HDAS.SNDW. Package (0x02) { "mipi-sdw-simplified-clockstopprepare-sm-supported", Zero }, Change-Id: If958cd0c2136e4dd3f60cb9203d9394913d3f66e Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> --- M src/drivers/soundwire/alc711/alc711.c M src/drivers/soundwire/alc711/chip.h 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/88586/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/88586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If958cd0c2136e4dd3f60cb9203d9394913d3f66e Gerrit-Change-Number: 88586 Gerrit-PatchSet: 12 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support
by Ian Feng (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Ian Feng, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Subrata Banik. Hello Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Mac Chiang, Mac Chiang, Pranava Y N, Shumingf -, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/88587?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Code-Review+1 by Mac Chiang, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support ...................................................................... mb/google/fatcat/var/francka: Disable ALC721 & ALC722 clock stop support This change allows flag to be override via devicetree, instead of relying on the default value in alc711_slave. It helps fix the issue where no event is generated when plugging or unplugging the 3.5mm headphone jack. BUG=b:417133565, b:420516709 TEST=Verified build and boot with ALC721 and ALC722. Headphone path switches successfully via audio jack event. Confirmed SSDT dump at PCI0.HDAS.SNDW. Package (0x02) { "mipi-sdw-simplified-clockstopprepare-sm-supported", Zero }, Change-Id: I975ed83e8614bd88861f115ffeea7c2450e6a432 Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> --- M src/mainboard/google/fatcat/variants/francka/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/88587/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/88587?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I975ed83e8614bd88861f115ffeea7c2450e6a432 Gerrit-Change-Number: 88587 Gerrit-PatchSet: 16 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/google/brox/var/caboc: Update hda_verb table
by Tony Huang (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Karthik Ramasubramanian. Hello Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/88627?usp=email to look at the new patch set (#2). Change subject: mb/google/brox/var/caboc: Update hda_verb table ...................................................................... mb/google/brox/var/caboc: Update hda_verb table Update hda_verb table from vendor. BUG=b:435345756 TEST=emerge-brox coreboot check system audio output is fine Change-Id: Id46d1798b605e7d1fbdfacf2e1899bfc40a113a6 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brox/variants/caboc/include/variant/hda_verb.h 1 file changed, 62 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/88627/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/88627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id46d1798b605e7d1fbdfacf2e1899bfc40a113a6 Gerrit-Change-Number: 88627 Gerrit-PatchSet: 2 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/brox/var/caboc: Update hda_verb table
by Tony Huang (Code Review) July 31, 2025

July 31, 2025

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/88627?usp=email ) Change subject: mb/google/brox/var/caboc: Update hda_verb table ...................................................................... mb/google/brox/var/caboc: Update hda_verb table Update hda_verb table from vendor. BUG=b:435345756 TEST=emerge-brox coreboot check system audio output is fine Change-Id: Id46d1798b605e7d1fbdfacf2e1899bfc40a113a6 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brox/variants/caboc/include/variant/hda_verb.h 1 file changed, 61 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/88627/1 diff --git a/src/mainboard/google/brox/variants/caboc/include/variant/hda_verb.h b/src/mainboard/google/brox/variants/caboc/include/variant/hda_verb.h index 9435ad7..5db2377 100644 --- a/src/mainboard/google/brox/variants/caboc/include/variant/hda_verb.h +++ b/src/mainboard/google/brox/variants/caboc/include/variant/hda_verb.h @@ -17,14 +17,24 @@ /* Pin Widget Verb Table */ + /* 1 bit reset */ + 0x0205001A, + 0x0204C003, + 0x0205001A, + 0x02048003, + 0x0205007F, + 0x02046001, + 0x0205007F, + 0x02040001, + /* * DMIC - * Requirement is to use PCH DMIC. Hence, - * commented out codec's Internal DMIC. - * AZALIA_PIN_CFG(0, 0x12, 0x90A60130), - * AZALIA_PIN_CFG(0, 0x13, 0x40000000), + * Internal DMIC */ - + /* Pin widget 0x12 - DMIC */ + AZALIA_PIN_CFG(0, 0x12, 0x411111F0), + /* Pin widget 0x13 - DMIC */ + AZALIA_PIN_CFG(0, 0x13, 0x40000000), /* Pin widget 0x14 - Front (Port-D) */ AZALIA_PIN_CFG(0, 0x14, 0x90170110), /* Pin widget 0x18 - NPC */ @@ -66,16 +76,36 @@ 0x057409A3, /* disable EQ first */ 0x05350000, - 0x0534201A, + 0x0534203A, /* Left Channel */ 0x0535001d, 0x05340800, 0x0535001e, 0x05340800, 0x05350003, - 0x05341F7B, + 0x05341F95, 0x05350004, 0x05340000, + 0x05350005, + 0x053403F6, + 0x05350006, + 0x0534854C, + 0x05350007, + 0x05341E09, + 0x05350008, + 0x05346472, + 0x05350009, + 0x053401FB, + 0x0535000A, + 0x05344836, + 0x0535000B, + 0x05341C00, + 0x0535000C, + 0x05340000, + 0x0535000D, + 0x05340200, + 0x0535000E, + 0x05340000, /* Right Channel */ 0x05450000, 0x05442000, @@ -84,15 +114,35 @@ 0x0545001e, 0x05440800, 0x05450003, - 0x05441F7B, + 0x05441F95, 0x05450004, 0x05440000, + 0x05450005, + 0x054403F6, + 0x05450006, + 0x0544854C, + 0x05450007, + 0x05441E09, + 0x05450008, + 0x05446472, + 0x05450009, + 0x054401FB, + 0x0545000A, + 0x05444836, + 0x0545000B, + 0x05441C00, + 0x0545000C, + 0x05440000, + 0x0545000D, + 0x05440200, + 0x0545000E, + 0x05440000, /* enable EQ */ 0x05350000, - 0x0534E01A, - /* 1.8W/4ohm */ + 0x0534E03A, + /* 2.2W/4ohm */ 0x02050038, - 0x02047901, + 0x02046901, /* AGC Enable */ 0x0205004C, 0x0204465C, -- To view, visit https://review.coreboot.org/c/coreboot/+/88627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id46d1798b605e7d1fbdfacf2e1899bfc40a113a6 Gerrit-Change-Number: 88627 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Create new kinmen4es variant
by Ivy Jian (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik. Ivy Jian has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/88622?usp=email ) Change subject: mb/google/fatcat: Create new kinmen4es variant ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/fatcat/Kconfig: https://review.coreboot.org/c/coreboot/+/88622/comment/7f30a9eb_9b3358de?us… : PS1, Line 188: default "Kinmen4ES" if BOARD_GOOGLE_KINMEN4ES > Use same MAINBOARD_PART_NUMBER for both kinmen and kinmen4es. Similar to https://review.coreboot. […] Done File src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h: https://review.coreboot.org/c/coreboot/+/88622/comment/c98d7442_1837c969?us… : PS1, Line 35: (CONFIG(BOARD_GOOGLE_KINMEN) || CONFIG(BOARD_GOOGLE_KINMEN4ES)) > BOARD_GOOGLE_MODEL_KINMEN can be used here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/88622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0597c1b63179e46a83286f2d46f958189f627cc Gerrit-Change-Number: 88622 Gerrit-PatchSet: 3 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 00:58:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>

1 0