coreboot-gerrit

Download

coreboot-gerrit@coreboot.org

August 2025

1 participants
2012 discussions

[XS] Change in coreboot[main]: drivers/soundwire/alc711: Support clock stop flag from devicetree
by Ian Feng (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Jayvik Desai, Mac Chiang, Pranava Y N, Shumingf -, Simon Yang. Ian Feng has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/88586?usp=email ) Change subject: drivers/soundwire/alc711: Support clock stop flag from devicetree ...................................................................... Patch Set 11: (1 comment) File src/drivers/soundwire/alc711/alc711.c: https://review.coreboot.org/c/coreboot/+/88586/comment/76236885_64ec0b13?us… : PS11, Line 135: alc711_slave.simplified_clockstopprepare_sm_supported = true; > can you try to remove this line? looks like it's unnecessary. I'll try it out. -- To view, visit https://review.coreboot.org/c/coreboot/+/88586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If958cd0c2136e4dd3f60cb9203d9394913d3f66e Gerrit-Change-Number: 88586 Gerrit-PatchSet: 11 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shumingf - <shumingf(a)realtek.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Aug 2025 00:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Create new kinmen4es variant
by Ivy Jian (Code Review) July 31, 2025

July 31, 2025

Attention is currently required from: Avi Uday, Dinesh Gehlot, Ivy Jian, Jayvik Desai, Kapil Porwal, Subrata Banik. Hello Avi Uday, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/88622?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: mb/google/fatcat: Create new kinmen4es variant ...................................................................... mb/google/fatcat: Create new kinmen4es variant This new variant will support PTL pre-production silicon. The existing `kinmen` variant will support production silicon. BUG=b:434847748 TEST=Able to build google/kinmen4es. Change-Id: If0597c1b63179e46a83286f2d46f958189f627cc Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/Kconfig.name M src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h 3 files changed, 20 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/88622/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/88622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0597c1b63179e46a83286f2d46f958189f627cc Gerrit-Change-Number: 88622 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>

1 0

Jump to page: