August 2025 - coreboot-gerrit - mail.coreboot.org

[XS] Change in coreboot[main]: mb/google/rex: Use IoT FSP on MeteorLake
by Alicja Michalska (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Ingo Reitz, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Paul Menzel, Subrata Banik, Tarun. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/88863?usp=email ) Change subject: mb/google/rex: Use IoT FSP on MeteorLake ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/88863/comment/198be119_32a08ced?us… : PS4, Line 7: MeteorLake > Meteor Lake FSP code disagrees 😜 -- To view, visit https://review.coreboot.org/c/coreboot/+/88863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I760620b538ca9e19d599cbbae9d09738a8e8e5c9 Gerrit-Change-Number: 88863 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sun, 31 Aug 2025 15:44:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/rex: Use IoT FSP on MeteorLake
by Paul Menzel (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Ingo Reitz, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Paul Menzel, Subrata Banik, Tarun. Paul Menzel has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/88863?usp=email ) Change subject: mb/google/rex: Use IoT FSP on MeteorLake ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/88863/comment/a4b82499_a79d4242?us… : PS4, Line 9: FSP Is 18.0.5.2141 the version? https://review.coreboot.org/c/coreboot/+/88863/comment/3911ea03_e1fc3fd1?us… : PS4, Line 33: [EMERG] FSP-M UPD size is larger than FSPM_UPD struct size. Maybe the struct size can be adapted. -- To view, visit https://review.coreboot.org/c/coreboot/+/88863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I760620b538ca9e19d599cbbae9d09738a8e8e5c9 Gerrit-Change-Number: 88863 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sun, 31 Aug 2025 15:41:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rex: Use IoT FSP on MeteorLake
by Alicja Michalska (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Ingo Reitz, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Paul Menzel, Subrata Banik, Tarun. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/88863?usp=email ) Change subject: mb/google/rex: Use IoT FSP on MeteorLake ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Upstream should also work with Google’s FSP. […] It would require sharing headers from CCG FSP, which AFAIK would be a violation of license. -- To view, visit https://review.coreboot.org/c/coreboot/+/88863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I760620b538ca9e19d599cbbae9d09738a8e8e5c9 Gerrit-Change-Number: 88863 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sun, 31 Aug 2025 15:41:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/rex: Use IoT FSP on MeteorLake
by Paul Menzel (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Alicja Michalska, Dinesh Gehlot, Eran Mitrani, Ingo Reitz, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Subrata Banik, Tarun. Paul Menzel has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/88863?usp=email ) Change subject: mb/google/rex: Use IoT FSP on MeteorLake ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Upstream should also work with Google’s FSP. It’d be great, if the Chromium OS folks could take a look. Commit Message: https://review.coreboot.org/c/coreboot/+/88863/comment/a7146f0f_54e08f94?us… : PS4, Line 7: MeteorLake Meteor Lake -- To view, visit https://review.coreboot.org/c/coreboot/+/88863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I760620b538ca9e19d599cbbae9d09738a8e8e5c9 Gerrit-Change-Number: 88863 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sun, 31 Aug 2025 15:40:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rex: Use IoT FSP on MeteorLake
by Alicja Michalska (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Alicja Michalska, Dinesh Gehlot, Eran Mitrani, Ingo Reitz, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Ingo Reitz, Jakub "Kuba" Czapiga, Kapil Porwal, Matt DeVillier, Subrata Banik, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/88863?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by Ingo Reitz, Code-Review+1 by Matt DeVillier Change subject: mb/google/rex: Use IoT FSP on MeteorLake ...................................................................... mb/google/rex: Use IoT FSP on MeteorLake Trying to build with Google's FSP results in non-bootable system: ``` [NOTE ] coreboot-24.12-1952-g774bd7853cf4-dirty-MrChromebox-25.06-dirty Sat Jun 28 16:33:41 UTC 2025 x86_. [DEBUG] pm1_sts: 0100 pm1_en: 0000 pm1_cnt: 00001c00 [DEBUG] gpe0_sts[0]: 00000000 gpe0_en[0]: 00000000 [DEBUG] gpe0_sts[1]: 00000008 gpe0_en[1]: 00000000 [DEBUG] gpe0_sts[2]: 00000000 gpe0_en[2]: 00000000 [DEBUG] gpe0_sts[3]: 00000000 gpe0_en[3]: 00092000 [DEBUG] TCO_STS: 0000 0000 [DEBUG] GEN_PMCON: d0015038 00002200 [DEBUG] GBLRST_CAUSE: 00000000 00000000 [DEBUG] HPR_CAUSE0: 00000000 [DEBUG] prev_sleep_state 5 (S5) [DEBUG] cse_lite: Number of partitions = 3 [DEBUG] cse_lite: Current partition = RO [DEBUG] cse_lite: Next partition = RO [DEBUG] cse_lite: Flags = 0x7 [DEBUG] cse_lite: RO version = 18.0.5.2141 (Start=0x2000, End=0x314fff) [DEBUG] cse_lite: RW version = 18.0.5.2141 (Start=0x37e000, End=0x72afff) [SPEW ] CBFS DEBUG: _cbfs_alloc(name='fspm.bin', alloc=0x00000000(0xfef87e98), force_ro=false, type=-1) [DEBUG] FMAP: area COREBOOT found @ 1c04200 (4177408 bytes) [INFO ] Fixed Decode Window: SPI flash base=0x1000000, Host base=0xff000000, Size=0x1000000 [INFO ] Extended Decode Window: SPI flash base=0x800000, Host base=0xf9800000, Size=0x800000 [INFO ] CBFS: Found 'fspm.bin' @0x77dc0 size 0xd0000 in mcache @0xfef8a404 [EMERG] FSP-M UPD size is larger than FSPM_UPD struct size. ``` Choosing IOT FSP results in working build, so let's depend on that if we're not building for ChromeOS :) TEST=build/flash google/rex/karis Change-Id: I760620b538ca9e19d599cbbae9d09738a8e8e5c9 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/google/rex/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/88863/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/88863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I760620b538ca9e19d599cbbae9d09738a8e8e5c9 Gerrit-Change-Number: 88863 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ingo Reitz <9l(a)9lo.re> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ingo Reitz <9l(a)9lo.re> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[L] Change in coreboot[main]: soc/amd/common/block/lpc: Add SPI DMA boot_device()
by Paul Menzel (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Felix Held, Patrick Rudolph. Paul Menzel has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/88590?usp=email ) Change subject: soc/amd/common/block/lpc: Add SPI DMA boot_device() ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/88590/comment/5fa529a4_a5e358da?us… : PS1, Line 16: enable enable*d* File src/soc/amd/common/block/lpc/dma.c: https://review.coreboot.org/c/coreboot/+/88590/comment/15ac05f4_3e3e145d?us… : PS1, Line 13: #if CONFIG_ROM_SIZE >= (16 * MiB) : #define ROM_SIZE (16 * MiB) : #else : #define ROM_SIZE CONFIG_ROM_SIZE : #endif Add a comment explaining the cut-off? https://review.coreboot.org/c/coreboot/+/88590/comment/33549933_a5374f6e?us… : PS1, Line 13: #if CONFIG_ROM_SIZE >= (16 * MiB) : #define ROM_SIZE (16 * MiB) : #else : #define ROM_SIZE CONFIG_ROM_SIZE : #endif Add a comment explaining the cut-off? -- To view, visit https://review.coreboot.org/c/coreboot/+/88590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88070824958c43dcd85cd86ac833b7236a088908 Gerrit-Change-Number: 88590 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 31 Aug 2025 12:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: commonlib/region: Add fallback_rdev
by Angel Pons (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/88589?usp=email ) Change subject: commonlib/region: Add fallback_rdev ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/88589?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf6b14555241566c8c3c07b4175f4e2b2e7e2366 Gerrit-Change-Number: 88589 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sun, 31 Aug 2025 12:23:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: soc/amd/common/block/lpc: Add SPI DMA boot_device()
by Angel Pons (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Felix Held, Patrick Rudolph. Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/88590?usp=email ) Change subject: soc/amd/common/block/lpc: Add SPI DMA boot_device() ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/common/block/lpc/dma.c: https://review.coreboot.org/c/coreboot/+/88590/comment/8c6778bd_b3edaf4b?us… : PS1, Line 207: if (spi_dma_is_busy()) > Hmm... okay, fair enough. […] I agree with Julius, I don't feel the `fallback_rdev` is of much help. Also, while reads could somehow be done simultaneously, wouldn't you need a mutex of some sort to handle writes? -- To view, visit https://review.coreboot.org/c/coreboot/+/88590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88070824958c43dcd85cd86ac833b7236a088908 Gerrit-Change-Number: 88590 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 31 Aug 2025 12:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[M] Change in coreboot[main]: commonlib/region: Add fallback_rdev
by Angel Pons (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/88589?usp=email ) Change subject: commonlib/region: Add fallback_rdev ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/88589?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf6b14555241566c8c3c07b4175f4e2b2e7e2366 Gerrit-Change-Number: 88589 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sun, 31 Aug 2025 12:20:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: ec/lenovo/h8: Turn on PWR LED
by Angel Pons (Code Review) Aug. 31, 2025

Aug. 31, 2025

Attention is currently required from: Alexander Couzens, Patrick Rudolph. Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/88998?usp=email ) Change subject: ec/lenovo/h8: Turn on PWR LED ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/88998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5fe3a52a6be622785c9588a94242ac0de0e19fa Gerrit-Change-Number: 88998 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 31 Aug 2025 12:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0