June 2025 - coreboot-gerrit - mail.coreboot.org

[S] Change in coreboot[main]: soc/qualcomm/common: Update QUP register structure for QUP v3.2
by Subrata Banik (Code Review) June 30, 2025

June 30, 2025

Attention is currently required from: Julius Werner, Swathi Tamilselvan. Subrata Banik has posted comments on this change by Swathi Tamilselvan. ( https://review.coreboot.org/c/coreboot/+/88190?usp=email ) Change subject: soc/qualcomm/common: Update QUP register structure for QUP v3.2 ...................................................................... Patch Set 4: (1 comment) File src/soc/qualcomm/common/clock.c: https://review.coreboot.org/c/coreboot/+/88190/comment/0ae08218_ca88d8d4?us… : PS4, Line 138: else > This will be true for WRAP2 as well. I missed this part during the review. for platform w/ QC_COMMON_QUPV3_2 Kconfig, we wish to program all three QUP wraps isn't it. -- To view, visit https://review.coreboot.org/c/coreboot/+/88190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304012d72a1af33510dcd620953367f0a9e98ac1 Gerrit-Change-Number: 88190 Gerrit-PatchSet: 4 Gerrit-Owner: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 16:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[S] Change in coreboot[main]: soc/qualcomm/common: Update QUP register structure for QUP v3.2
by Subrata Banik (Code Review) June 30, 2025

June 30, 2025

Attention is currently required from: Julius Werner, Swathi Tamilselvan. Subrata Banik has posted comments on this change by Swathi Tamilselvan. ( https://review.coreboot.org/c/coreboot/+/88190?usp=email ) Change subject: soc/qualcomm/common: Update QUP register structure for QUP v3.2 ...................................................................... Patch Set 4: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/88190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304012d72a1af33510dcd620953367f0a9e98ac1 Gerrit-Change-Number: 88190 Gerrit-PatchSet: 4 Gerrit-Owner: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 16:33:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/qualcomm/common: Update QUP register structure for QUP v3.2
by Kapil Porwal (Code Review) June 30, 2025

June 30, 2025

Attention is currently required from: Julius Werner, Swathi Tamilselvan. Kapil Porwal has posted comments on this change by Swathi Tamilselvan. ( https://review.coreboot.org/c/coreboot/+/88190?usp=email ) Change subject: soc/qualcomm/common: Update QUP register structure for QUP v3.2 ...................................................................... Patch Set 4: (1 comment) File src/soc/qualcomm/common/clock.c: https://review.coreboot.org/c/coreboot/+/88190/comment/f006e6c7_15958404?us… : PS4, Line 134: #endif You are missing this from Julius's suggestion. ```suggestion else #endif ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/88190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304012d72a1af33510dcd620953367f0a9e98ac1 Gerrit-Change-Number: 88190 Gerrit-PatchSet: 4 Gerrit-Owner: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 16:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/qualcomm/common: Update QUP register structure for QUP v3.2
by Kapil Porwal (Code Review) June 30, 2025

June 30, 2025

Attention is currently required from: Julius Werner, Swathi Tamilselvan. Kapil Porwal has posted comments on this change by Swathi Tamilselvan. ( https://review.coreboot.org/c/coreboot/+/88190?usp=email ) Change subject: soc/qualcomm/common: Update QUP register structure for QUP v3.2 ...................................................................... Patch Set 4: (1 comment) File src/soc/qualcomm/common/clock.c: https://review.coreboot.org/c/coreboot/+/88190/comment/cbb82888_761d1334?us… : PS4, Line 138: else This will be true for WRAP2 as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/88190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304012d72a1af33510dcd620953367f0a9e98ac1 Gerrit-Change-Number: 88190 Gerrit-PatchSet: 4 Gerrit-Owner: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Swathi Tamilselvan <tswathi(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 16:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: crossgcc: Upgrade GCC from 14.2.0 to 15.1.0
by Elyes Haouas (Code Review) June 30, 2025

June 30, 2025

Hello Felix Singer, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86100?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: crossgcc: Upgrade GCC from 14.2.0 to 15.1.0 ...................................................................... crossgcc: Upgrade GCC from 14.2.0 to 15.1.0 Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-15.1.0_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15.1.0_gnat.patch R util/crossgcc/patches/gcc-15.1.0_libcpp.patch R util/crossgcc/patches/gcc-15.1.0_libgcc.patch R util/crossgcc/patches/gcc-15.1.0_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15.1.0_rv32iafc.patch D util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-15.1.0.tar.xz.cksum 9 files changed, 47 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/86100/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/86100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Gerrit-Change-Number: 86100 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[M] Change in coreboot[main]: crossgcc: Upgrade GCC from 14.2.0 to 15.1.0
by Elyes Haouas (Code Review) June 30, 2025

June 30, 2025

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/86100?usp=email ) Change subject: crossgcc: Upgrade GCC from 14.2.0 to 15.1.0 ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/86100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Gerrit-Change-Number: 86100 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[L] Change in coreboot[main]: crossgcc: upgrade binutils from version 2.43 to 2.44
by Elyes Haouas (Code Review) June 30, 2025

June 30, 2025

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86254?usp=email ) Change subject: crossgcc: upgrade binutils from version 2.43 to 2.44 ...................................................................... Patch Set 13: (1 comment) File util/crossgcc/patches/binutils-2.43.1_as-ipxe.patch: PS12: > Mention the removal in the commit message? that was a mistake -- To view, visit https://review.coreboot.org/c/coreboot/+/86254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Gerrit-Change-Number: 86254 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 30 Jun 2025 15:51:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: crossgcc: upgrade binutils from version 2.43 to 2.44
by Elyes Haouas (Code Review) June 30, 2025

June 30, 2025

Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86254?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: crossgcc: upgrade binutils from version 2.43 to 2.44 ...................................................................... crossgcc: upgrade binutils from version 2.43 to 2.44 Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/patches/binutils-2.43.1_no-makeinfo.patch R util/crossgcc/patches/binutils-2.44_as-ipxe.patch A util/crossgcc/patches/binutils-2.44_no-makeinfo.patch D util/crossgcc/sum/binutils-2.43.1.tar.xz.cksum A util/crossgcc/sum/binutils-2.44.tar.xz.cksum 6 files changed, 221 insertions(+), 257 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/86254/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/86254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Gerrit-Change-Number: 86254 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: crossgcc: upgrade binutils from version 2.43 to 2.44
by Elyes Haouas (Code Review) June 30, 2025

June 30, 2025

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/86254?usp=email ) Change subject: crossgcc: upgrade binutils from version 2.43 to 2.44 ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/86254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Gerrit-Change-Number: 86254 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: drivers/crb/tpm: Add new method to retrieve base address
by Tim Wawrzynczak (Code Review) June 30, 2025

June 30, 2025

Attention is currently required from: Cliff Huang, Lance Zhao, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/88249?usp=email ) Change subject: drivers/crb/tpm: Add new method to retrieve base address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/88249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I29c81d82947eb2603472a515f9ada598e4f8e6ea Gerrit-Change-Number: 88249 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 15:39:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0