December 2025 - coreboot-gerrit

[M] Change in coreboot[main]: mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp...
by Keith Hui (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Matt DeVillier. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/90655?usp=email ) Change subject: mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp_*() ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > is there a reason to use a temp copy here vs the copy in sio/nuvoton/early_serial. […] I just tried that. early_serial.c did not define `__SIMPLE_DEVICE__`, so when compiled for ramstage (along with mainboard.c) the functions `nuvoton_enable_serial()` call expect a full `struct device *` instead of `pnp_devfn_t`, resulting in build errors. This patch must either invade early_serial.c to add that define or roll its own copy without it (which is nuvoton.c). The final patch does touch early_serial.c though. All this would be unnecessary if you're OK with me fixing both Asrock boards along with the refactoring all in CB:90657. -- To view, visit https://review.coreboot.org/c/coreboot/+/90655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I685ebe6c2bb638d815ccf1fcdd1d73edc176c69e Gerrit-Change-Number: 90655 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 31 Dec 2025 23:00:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp...
by Matt DeVillier (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Keith Hui. Matt DeVillier has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/90655?usp=email ) Change subject: mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp_*() ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: is there a reason to use a temp copy here vs the copy in sio/nuvoton/early_serial.c? You could just temp modify the makefile there to compile it for SMM too? -- To view, visit https://review.coreboot.org/c/coreboot/+/90655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I685ebe6c2bb638d815ccf1fcdd1d73edc176c69e Gerrit-Change-Number: 90655 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 31 Dec 2025 22:13:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state()
by Keith Hui (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Matt DeVillier. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/90657?usp=email ) Change subject: sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state() ...................................................................... Patch Set 4: (2 comments) Patchset: PS1: > reflow commit msg to 72 char plz Done Commit Message: https://review.coreboot.org/c/coreboot/+/90657/comment/1812e038_78e06bca?us… : PS3, Line 11: __SIMPLE_DEVICE__ > next line Done -- To view, visit https://review.coreboot.org/c/coreboot/+/90657?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0238f006dd86742f937e9dcd6134ed7be566677c Gerrit-Change-Number: 90657 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 31 Dec 2025 21:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state()
by Keith Hui (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Keith Hui. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/90657?usp=email to look at the new patch set (#4). Change subject: sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state() ...................................................................... sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state() Move the pair of non-ramstage Nuvoton SIO PNP config mode entry/exit functions from early_serial.c into nuvoton.h as inline functions for both pre-RAM and SMM code use. Availability is limited to __SIMPLE_DEVICE__ environments, or if this symbol is defined such as when mainboards specifically request it. Cuts outdated comment from early_serial.c and transplant its key parts to nuvoton.h. Remove the temporarily refactored local copies from mb/asrock/{z87_extreme4,fatal1ty_z87_professional}. Build tested on these two Asrock boards and asus/p8x7x-series. Change-Id: I0238f006dd86742f937e9dcd6134ed7be566677c Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asrock/fatal1ty_z87_professional/Makefile.mk D src/mainboard/asrock/fatal1ty_z87_professional/nuvoton.c M src/mainboard/asrock/z87_extreme4/Makefile.mk D src/mainboard/asrock/z87_extreme4/nuvoton.c M src/superio/nuvoton/common/early_serial.c M src/superio/nuvoton/common/nuvoton.h 6 files changed, 26 insertions(+), 88 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/90657/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/90657?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0238f006dd86742f937e9dcd6134ed7be566677c Gerrit-Change-Number: 90657 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com>

1 0

[S] Change in coreboot[main]: MAINTAINERS: Remove non-existant mainboards
by Paul Menzel (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Nicholas Sudsgaard. Paul Menzel has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/89504?usp=email ) Change subject: MAINTAINERS: Remove non-existant mainboards ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > -2. […] @Mike, I think there was no harm intended. People expect that only code actually in the repository is mentioned in `MAINTAINERS`. This is indeed a special case here. Have you created the revert yet? -- To view, visit https://review.coreboot.org/c/coreboot/+/89504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41c386a6f61efd20cfd52ce5b71412b1f9e9181f Gerrit-Change-Number: 89504 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Name of user not set #1000508 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Comment-Date: Wed, 31 Dec 2025 17:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mike Banon <mikebdp2(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asus: Add H81M-K
by Paul Menzel (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Nicholas, Patrick Rudolph, kisekinopureya. Paul Menzel has posted comments on this change by kisekinopureya. ( https://review.coreboot.org/c/coreboot/+/88075?usp=email ) Change subject: mb/asus: Add H81M-K ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/88075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib68c198b378ef02a9aec0619536c6c9363d8a50c Gerrit-Change-Number: 88075 Gerrit-PatchSet: 19 Gerrit-Owner: kisekinopureya <gokhan.ozdemir(a)kisekinopureya.com.tr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas <nic.c3.14(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Attention: kisekinopureya <gokhan.ozdemir(a)kisekinopureya.com.tr> Gerrit-Comment-Date: Wed, 31 Dec 2025 17:26:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/skywalker: Extend MIPI panel delay to meet T3 timing
by Paul Menzel (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Hung-Te Lin, Yang Wu, Yidi Lin, Yu-Ping Wu. Paul Menzel has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/90664?usp=email ) Change subject: mb/google/skywalker: Extend MIPI panel delay to meet T3 timing ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/90664/comment/add91357_f7e44635?us… : PS1, Line 8: Please start by describing the problem. https://review.coreboot.org/c/coreboot/+/90664/comment/d06a3729_dfda478f?us… : PS1, Line 10: T3(AVEE-to-RESET) Please add a space before (. -- To view, visit https://review.coreboot.org/c/coreboot/+/90664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ided93c34f7c6695a2928c23eea679f32a0ee9a17 Gerrit-Change-Number: 90664 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Zhengqiao Xia <xiazhengqiao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 31 Dec 2025 16:47:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state()
by Matt DeVillier (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Keith Hui. Matt DeVillier has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/90657?usp=email ) Change subject: sio/nuvoton/common: Refactor nuvoton_pnp_*_config_state() ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/90657/comment/a64ab8eb_b5d2d6f7?us… : PS3, Line 11: __SIMPLE_DEVICE__ next line -- To view, visit https://review.coreboot.org/c/coreboot/+/90657?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0238f006dd86742f937e9dcd6134ed7be566677c Gerrit-Change-Number: 90657 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 31 Dec 2025 16:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp...
by Keith Hui (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/90655?usp=email to look at the new patch set (#3). Change subject: mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp_*() ...................................................................... mb/asrock/fatal1ty_z87_professional: Temporarily refactor nuvoton_pnp_*() As the pair of non-ramstage Nuvoton SIO config mode entry/exit functions see wider use, they are being moved to sio/nuvoton/common/. This mainboard carries 2 local copies. This preparatory patch moves it out of smihandler.c into a temporary C file to prevent build breakage. It is to be removed when the shared copy is in place. WARNING: Disassembly of compiled SMM code shows a possible stack issue. Do not flash a binary with this patch applied but without the final shared version above. Change-Id: I685ebe6c2bb638d815ccf1fcdd1d73edc176c69e Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asrock/fatal1ty_z87_professional/Makefile.mk M src/mainboard/asrock/fatal1ty_z87_professional/mainboard.c A src/mainboard/asrock/fatal1ty_z87_professional/nuvoton.c M src/mainboard/asrock/fatal1ty_z87_professional/smihandler.c 4 files changed, 26 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/90655/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/90655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I685ebe6c2bb638d815ccf1fcdd1d73edc176c69e Gerrit-Change-Number: 90655 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/asrock/z87_extreme4: Temporarily refactor nuvoton_pnp_*_conf_state()
by Keith Hui (Code Review) Dec. 31, 2025

Dec. 31, 2025

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/90656?usp=email to look at the new patch set (#3). Change subject: mb/asrock/z87_extreme4: Temporarily refactor nuvoton_pnp_*_conf_state() ...................................................................... mb/asrock/z87_extreme4: Temporarily refactor nuvoton_pnp_*_conf_state() As the pair of non-ramstage Nuvoton SIO config mode entry/exit functions see wider use, they are being moved to sio/nuvoton/common. This mainboard carries 2 local copies. This preparatory patch moves them out of smihandler.c and mainboard.c into a temporary C file to prevent build breakage. It is to be removed when the shared copy is in place. WARNING: Disassembly of compiled SMM code shows a possible stack issue. Do not flash a binary with this patch applied but without the final shared version above. Change-Id: I7a5394478281ac3b92d257e2f0201264b95bb4e5 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asrock/z87_extreme4/Makefile.mk M src/mainboard/asrock/z87_extreme4/mainboard.c A src/mainboard/asrock/z87_extreme4/nuvoton.c M src/mainboard/asrock/z87_extreme4/smihandler.c 4 files changed, 26 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/90656/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/90656?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a5394478281ac3b92d257e2f0201264b95bb4e5 Gerrit-Change-Number: 90656 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0