July 2013 - coreboot-gerrit - mail.coreboot.org

Patch merged into coreboot/master: 260c33b ec/kontron/it8516e: Remove some unsafe bit shifting
by gerrit＠coreboot.org July 29, 2013

July 29, 2013

the following patch was just integrated into master: commit 260c33ba5619dba58c6e32ba998931325fe8086c Author: Nico Huber <nico.huber(a)secunet.com> Date: Thu Jul 18 11:27:30 2013 +0200 ec/kontron/it8516e: Remove some unsafe bit shifting The EC expects the temperature in 64ths degree C. Alter it8516e_set_fan_temperature() to just export this interface and make the calculation more obvious. Change-Id: Ibe241b7909f4c02b30b1e1200a1850d47695a765 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/3785 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3785 for details. -gerrit

1 0

Patch merged into coreboot/master: 8e1a7cc kontron/ktqm77: Squeeze more fan options into cmos.layout
by gerrit＠coreboot.org July 29, 2013

July 29, 2013

the following patch was just integrated into master: commit 8e1a7cc06fa596516dee5e083106f2ef4cd1c39f Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Jul 12 14:47:50 2013 +0200 kontron/ktqm77: Squeeze more fan options into cmos.layout Change-Id: Ic660efec519a9a970ec5a8832fd1dd8c9516318f Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/3775 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/3775 for details. -gerrit

1 0

Patch merged into coreboot/master: 9ce71b3 ec/kontron/it8516e: Add PWM limits option
by gerrit＠coreboot.org July 29, 2013

July 29, 2013

the following patch was just integrated into master: commit 9ce71b3cca0b59fdc262d89dafc8f75efbc167a6 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Jul 12 14:43:11 2013 +0200 ec/kontron/it8516e: Add PWM limits option Add an option to set minimal and maximal PWM percentages when the fan is in temperature controlled mode. Also fix a non-ascii flaw. Change-Id: I85ae244bee2145bf17d6c29e93dd4871540985c8 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/3774 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/3774 for details. -gerrit

1 0

Patch merged into coreboot/master: 942b6c2 ec/kontron/it8516e: Correct fan setting for PWM mode
by gerrit＠coreboot.org July 29, 2013

July 29, 2013

the following patch was just integrated into master: commit 942b6c2117816dcabdf15109b68aca33edee89c9 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Jul 12 14:40:23 2013 +0200 ec/kontron/it8516e: Correct fan setting for PWM mode The EC firmware expects a 255th while we provide a percentage. Change-Id: Ib06a061b431ac728329043179800729e39e6166b Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/3773 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/3773 for details. -gerrit

1 0

Patch merged into coreboot/master: 6d6a2ac ec/kontron/it8516e: Add option for external temperature sensor
by gerrit＠coreboot.org July 29, 2013

July 29, 2013

the following patch was just integrated into master: commit 6d6a2ac0559a324603d1c323239e2e6e6e58af77 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Jul 12 14:35:00 2013 +0200 ec/kontron/it8516e: Add option for external temperature sensor The IT8516E firmware of Kontron supports some selected external sensors attached to the EC via SMBUS or GPIO16. Change-Id: I4c451c360a393e916430e3bea04a95847455cef7 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: http://review.coreboot.org/3772 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/3772 for details. -gerrit

1 0

New patch to review for coreboot: 2059420 Fix up Stumpy/Lumpy PEI data for system agent r6
by Stefan Reinauer July 29, 2013

July 29, 2013

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3831 -gerrit commit 205942033e66b1646b4d43b5c7a030f11afb8a65 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Jul 29 14:02:06 2013 -0700 Fix up Stumpy/Lumpy PEI data for system agent r6 Change-Id: I79937fd1671af23184ab830d5ba6242c8067d944 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/mainboard/samsung/lumpy/romstage.c | 45 +++++++++++++++------------------ src/mainboard/samsung/stumpy/romstage.c | 2 +- 2 files changed, 22 insertions(+), 25 deletions(-) diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c index be1411e..92f24c6 100644 --- a/src/mainboard/samsung/lumpy/romstage.c +++ b/src/mainboard/samsung/lumpy/romstage.c @@ -146,33 +146,32 @@ void main(unsigned long bist) .hi = pci_read_config32(PCI_DEV(0, 0x1f, 2), 0xd0) }; #endif - struct pei_data pei_data = { - .pei_version = PEI_VERSION, - .mchbar = DEFAULT_MCHBAR, - .dmibar = DEFAULT_DMIBAR, - .epbar = DEFAULT_EPBAR, - .pciexbar = CONFIG_MMCONF_BASE_ADDRESS, - .smbusbar = SMBUS_IO_BASE, - .wdbbar = 0x4000000, - .wdbsize = 0x1000, - .hpet_address = CONFIG_HPET_ADDRESS, - .rcba = DEFAULT_RCBABASE, - .pmbase = DEFAULT_PMBASE, - .gpiobase = DEFAULT_GPIOBASE, - .thermalbase = 0xfed08000, - .system_type = 0, // 0 Mobile, 1 Desktop/Server - .tseg_size = CONFIG_SMM_TSEG_SIZE, - .spd_addresses = { 0x50, 0x00,0xf0,0x00 }, - .ts_addresses = { 0x30, 0x00, 0x00, 0x00 }, - .ec_present = 1, + pei_version: PEI_VERSION, + mchbar: DEFAULT_MCHBAR, + dmibar: DEFAULT_DMIBAR, + epbar: DEFAULT_EPBAR, + pciexbar: CONFIG_MMCONF_BASE_ADDRESS, + smbusbar: SMBUS_IO_BASE, + wdbbar: 0x4000000, + wdbsize: 0x1000, + hpet_address: CONFIG_HPET_ADDRESS, + rcba: DEFAULT_RCBABASE, + pmbase: DEFAULT_PMBASE, + gpiobase: DEFAULT_GPIOBASE, + thermalbase: 0xfed08000, + system_type: 0, // 0 Mobile, 1 Desktop/Server + tseg_size: CONFIG_SMM_TSEG_SIZE, + spd_addresses: { 0xa0, 0x00,0x00,0x00 }, + ts_addresses: { 0x30, 0x00, 0x00, 0x00 }, + ec_present: 1, // 0 = leave channel enabled // 1 = disable dimm 0 on channel // 2 = disable dimm 1 on channel // 3 = disable dimm 0+1 on channel - .dimm_channel0_disabled = 2, - .dimm_channel1_disabled = 2, - .usb_port_config = { + dimm_channel0_disabled: 2, + dimm_channel1_disabled: 2, + usb_port_config: { { 1, 0, 0x0080 }, /* P0: Port 0 (OC0) */ { 1, 1, 0x0080 }, /* P1: Port 1 (OC1) */ { 1, 0, 0x0040 }, /* P2: MINIPCIE1 (no OC) */ @@ -188,8 +187,6 @@ void main(unsigned long bist) { 0, 4, 0x0000 }, /* P12: Empty */ { 0, 4, 0x0000 }, /* P13: Empty */ }, - .spd_data = { - } }; typedef const uint8_t spd_blob[256]; diff --git a/src/mainboard/samsung/stumpy/romstage.c b/src/mainboard/samsung/stumpy/romstage.c index f64e860..44c171f 100644 --- a/src/mainboard/samsung/stumpy/romstage.c +++ b/src/mainboard/samsung/stumpy/romstage.c @@ -198,7 +198,7 @@ void main(unsigned long bist) thermalbase: 0xfed08000, system_type: 0, // 0 Mobile, 1 Desktop/Server tseg_size: CONFIG_SMM_TSEG_SIZE, - spd_addresses: { 0x50, 0x00,0x52,0x00 }, + spd_addresses: { 0xa0, 0x00,0xa4,0x00 }, ts_addresses: { 0x00, 0x00, 0x00, 0x00 }, ec_present: 0, // 0 = leave channel enabled

1 0

New patch to review for coreboot: 3fc5aae Drop unused EXTERNAL_MRC_BLOB
by Stefan Reinauer July 29, 2013

July 29, 2013

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3829 -gerrit commit 3fc5aaed2b96c1ad08dfa6cb1e34c9b306cf4a06 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Jul 29 12:43:06 2013 -0700 Drop unused EXTERNAL_MRC_BLOB The Kconfig variable EXTERNAL_MRC_BLOB is not used. Drop it. Change-Id: I3caa5c2b6bcf5d2c13b6987da8ab3987bad0e506 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/mainboard/google/butterfly/Kconfig | 1 - src/mainboard/google/link/Kconfig | 1 - src/mainboard/google/parrot/Kconfig | 1 - src/mainboard/google/stout/Kconfig | 1 - src/mainboard/intel/baskingridge/Kconfig | 1 - src/mainboard/intel/emeraldlake2/Kconfig | 1 - src/mainboard/intel/wtm2/Kconfig | 1 - src/mainboard/kontron/ktqm77/Kconfig | 1 - src/mainboard/samsung/lumpy/Kconfig | 1 - src/mainboard/samsung/stumpy/Kconfig | 1 - src/northbridge/intel/haswell/Kconfig | 4 ---- src/northbridge/intel/sandybridge/Kconfig | 4 ---- 12 files changed, 18 deletions(-) diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index be585c7..e9ad6ef 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_SMI_HANDLER select GFXUMA select CHROMEOS - select EXTERNAL_MRC_BLOB select EARLY_CBMEM_INIT # Workaround for EC/KBC IRQ1. diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index f62d690..b74c604 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_SMI_HANDLER select GFXUMA select CHROMEOS - select EXTERNAL_MRC_BLOB select SERIRQ_CONTINUOUS_MODE select MAINBOARD_HAS_NATIVE_VGA_INIT select EARLY_CBMEM_INIT diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index dbdb5fa..191e856 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_SMI_HANDLER select GFXUMA select CHROMEOS - select EXTERNAL_MRC_BLOB select EARLY_CBMEM_INIT # Workaround for EC/KBC IRQ1. diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index a5b7962..a316277 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_SMI_HANDLER select GFXUMA select CHROMEOS - select EXTERNAL_MRC_BLOB config MAINBOARD_DIR string diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index 163ccc9..cf4a901 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -12,7 +12,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_RESUME select HAVE_SMI_HANDLER select CHROMEOS - select EXTERNAL_MRC_BLOB config MAINBOARD_DIR string diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 786e9a8..fd98485 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -13,7 +13,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_RESUME select GFXUMA #select CHROMEOS - select EXTERNAL_MRC_BLOB select EARLY_CBMEM_INIT config MAINBOARD_DIR diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig index abfd168..dfee8ab 100644 --- a/src/mainboard/intel/wtm2/Kconfig +++ b/src/mainboard/intel/wtm2/Kconfig @@ -13,7 +13,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_RESUME select HAVE_SMI_HANDLER select CHROMEOS - select EXTERNAL_MRC_BLOB select CACHE_ROM select MARK_GRAPHICS_MEM_WRCOMB select MAINBOARD_HAS_NATIVE_VGA_INIT diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 97d8e5c..1665a25 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_RESUME select HAVE_SMI_HANDLER select GFXUMA - select EXTERNAL_MRC_BLOB select EARLY_CBMEM_INIT select ENABLE_VMX select HAVE_MRC diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 1c18ec2..778ce71 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -7,7 +7,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select CHROMEOS select CPU_INTEL_SOCKET_RPGA989 select EC_SMSC_MEC1308 - select EXTERNAL_MRC_BLOB select GFXUMA select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index f4df8a9..5300be5 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -6,7 +6,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_8192 select CHROMEOS select CPU_INTEL_SOCKET_RPGA989 - select EXTERNAL_MRC_BLOB select GFXUMA select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig index 72ea080..4b15c7b 100644 --- a/src/northbridge/intel/haswell/Kconfig +++ b/src/northbridge/intel/haswell/Kconfig @@ -35,10 +35,6 @@ config VGA_BIOS_ID string default "8086,0166" -config EXTERNAL_MRC_BLOB - bool - default n - config CACHE_MRC_SIZE_KB int default 512 diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 59b6187..1834b71 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -72,10 +72,6 @@ config VGA_BIOS_ID string default "8086,0166" -config EXTERNAL_MRC_BLOB - bool - default n - config CACHE_MRC_SIZE_KB int default 512

1 0

New patch to review for coreboot: 8a4094b Sandybridge/Ivybridge: Unify and fix Kconfig defaults
by Stefan Reinauer July 29, 2013

July 29, 2013

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3830 -gerrit commit 8a4094bdd3f04b3e650f402dbab306cb5f385629 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Jul 29 13:00:03 2013 -0700 Sandybridge/Ivybridge: Unify and fix Kconfig defaults Change-Id: Ia4a5530e6a1a1fd2dec6f348ff163b5c7a8cd4cd Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/northbridge/intel/sandybridge/Kconfig | 43 ++----------------------------- 1 file changed, 2 insertions(+), 41 deletions(-) diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 1834b71..42b044d 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -31,7 +31,7 @@ config NORTHBRIDGE_INTEL_IVYBRIDGE select MMCONF_SUPPORT_DEFAULT select CPU_INTEL_MODEL_306AX -if NORTHBRIDGE_INTEL_SANDYBRIDGE +if NORTHBRIDGE_INTEL_SANDYBRIDGE || NORTHBRIDGE_INTEL_IVYBRIDGE config VGA_BIOS_ID string @@ -39,41 +39,6 @@ config VGA_BIOS_ID config CACHE_MRC_SIZE_KB int - default 256 - -# FIXME: build from rom size -config MRC_CACHE_BASE - hex - default 0xff800000 - -config MRC_CACHE_LOCATION - hex - depends on !CHROMEOS - default 0x1ec000 - -config MRC_CACHE_SIZE - hex - depends on !CHROMEOS - default 0x10000 - -config DCACHE_RAM_BASE - hex - default 0xff7f0000 - -config DCACHE_RAM_SIZE - hex - default 0x10000 - -endif - -if NORTHBRIDGE_INTEL_IVYBRIDGE - -config VGA_BIOS_ID - string - default "8086,0166" - -config CACHE_MRC_SIZE_KB - int default 512 # FIXME: build from rom size @@ -99,10 +64,6 @@ config DCACHE_RAM_SIZE hex default 0x20000 -endif - -if NORTHBRIDGE_INTEL_SANDYBRIDGE || NORTHBRIDGE_INTEL_IVYBRIDGE - config BOOTBLOCK_NORTHBRIDGE_INIT string default "northbridge/intel/sandybridge/bootblock.c" @@ -122,7 +83,7 @@ config HAVE_MRC config MRC_FILE string "Intel System Agent path and filename" depends on HAVE_MRC - default "systemagent-r6.bin" + default "3rdparty/northbridge/intel/sandybridge/systemagent-r6.bin" help The path and filename of the file to use as System Agent binary.

1 0

New patch to review for coreboot: 5791756 usbdebug: Fix missing include
by Kyösti Mälkki July 28, 2013

July 28, 2013

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3828 -gerrit commit 5791756225154694e7619186901e24b38cd39bce Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sun Jul 28 23:16:47 2013 +0300 usbdebug: Fix missing include Change-Id: I74d28c13e6597c56e3b85ccd2b83386b86c200f0 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/lib/usbdebug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c index 77bfd97..0d50201 100644 --- a/src/lib/usbdebug.c +++ b/src/lib/usbdebug.c @@ -24,6 +24,7 @@ #include <device/pci.h> #include <arch/byteorder.h> #include <cpu/x86/car.h> +#include <string.h> #include <usb_ch9.h> #include <ehci.h>

1 0

New patch to review for coreboot: 7dfd061 Makefile: Fix adding intel/common
by Kyösti Mälkki July 28, 2013

July 28, 2013

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3827 -gerrit commit 7dfd0614689e97ed7ab74acfb6b9a845aa65a98f Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sun Jul 28 23:39:37 2013 +0300 Makefile: Fix adding intel/common Directory intel/common must be conditionally added in the list of source directories, as the parent directory southbridge/intel is unconditionally added even for boards without such device. Change-Id: I7088bc6db9f56909ffa996aa7eff76cd72e177eb Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/southbridge/intel/Kconfig | 1 + src/southbridge/intel/Makefile.inc | 2 +- src/southbridge/intel/bd82x6x/Kconfig | 1 + src/southbridge/intel/common/Kconfig | 2 ++ src/southbridge/intel/i82801dx/Kconfig | 1 + src/southbridge/intel/i82801ex/Kconfig | 1 + src/southbridge/intel/i82801gx/Kconfig | 1 + src/southbridge/intel/i82801ix/Kconfig | 1 + src/southbridge/intel/lynxpoint/Kconfig | 1 + src/southbridge/intel/sch/Kconfig | 1 + 10 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/southbridge/intel/Kconfig b/src/southbridge/intel/Kconfig index 5637c4a..788d3e1 100644 --- a/src/southbridge/intel/Kconfig +++ b/src/southbridge/intel/Kconfig @@ -1,3 +1,4 @@ +source src/southbridge/intel/common/Kconfig source src/southbridge/intel/esb6300/Kconfig source src/southbridge/intel/i3100/Kconfig source src/southbridge/intel/i82371eb/Kconfig diff --git a/src/southbridge/intel/Makefile.inc b/src/southbridge/intel/Makefile.inc index d795618..8f48caa 100644 --- a/src/southbridge/intel/Makefile.inc +++ b/src/southbridge/intel/Makefile.inc @@ -1,4 +1,4 @@ -subdirs-y += common +subdirs-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON) += common subdirs-$(CONFIG_SOUTHBRIDGE_INTEL_ESB6300) += esb6300 subdirs-$(CONFIG_SOUTHBRIDGE_INTEL_I3100) += i3100 subdirs-$(CONFIG_SOUTHBRIDGE_INTEL_I82371EB) += i82371eb diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig index e6a4fc8..bf020f8 100644 --- a/src/southbridge/intel/bd82x6x/Kconfig +++ b/src/southbridge/intel/bd82x6x/Kconfig @@ -27,6 +27,7 @@ if SOUTHBRIDGE_INTEL_BD82X6X || SOUTHBRIDGE_INTEL_C216 config SOUTH_BRIDGE_OPTIONS # dummy def_bool y + select SOUTHBRIDGE_INTEL_COMMON select IOAPIC select HAVE_HARD_RESET select HAVE_USBDEBUG diff --git a/src/southbridge/intel/common/Kconfig b/src/southbridge/intel/common/Kconfig new file mode 100644 index 0000000..949310b --- /dev/null +++ b/src/southbridge/intel/common/Kconfig @@ -0,0 +1,2 @@ +config SOUTHBRIDGE_INTEL_COMMON + def_bool n diff --git a/src/southbridge/intel/i82801dx/Kconfig b/src/southbridge/intel/i82801dx/Kconfig index 4a43458..f7f93a7 100644 --- a/src/southbridge/intel/i82801dx/Kconfig +++ b/src/southbridge/intel/i82801dx/Kconfig @@ -21,6 +21,7 @@ config SOUTHBRIDGE_INTEL_I82801DX bool + select SOUTHBRIDGE_INTEL_COMMON select IOAPIC select HAVE_HARD_RESET select HAVE_SMI_HANDLER diff --git a/src/southbridge/intel/i82801ex/Kconfig b/src/southbridge/intel/i82801ex/Kconfig index b1d7dbb..e4e9160 100644 --- a/src/southbridge/intel/i82801ex/Kconfig +++ b/src/southbridge/intel/i82801ex/Kconfig @@ -1,5 +1,6 @@ config SOUTHBRIDGE_INTEL_I82801EX bool + select SOUTHBRIDGE_INTEL_COMMON select IOAPIC select HAVE_HARD_RESET select HAVE_USBDEBUG diff --git a/src/southbridge/intel/i82801gx/Kconfig b/src/southbridge/intel/i82801gx/Kconfig index a991f60..d4a6baa 100644 --- a/src/southbridge/intel/i82801gx/Kconfig +++ b/src/southbridge/intel/i82801gx/Kconfig @@ -19,6 +19,7 @@ config SOUTHBRIDGE_INTEL_I82801GX bool + select SOUTHBRIDGE_INTEL_COMMON select IOAPIC select HAVE_HARD_RESET select HAVE_USBDEBUG diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index 36cfefb..dd07dac 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -20,6 +20,7 @@ config SOUTHBRIDGE_INTEL_I82801IX bool + select SOUTHBRIDGE_INTEL_COMMON select IOAPIC select HAVE_USBDEBUG select HAVE_HARD_RESET diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig index bd4f8d0..79aba6c 100644 --- a/src/southbridge/intel/lynxpoint/Kconfig +++ b/src/southbridge/intel/lynxpoint/Kconfig @@ -24,6 +24,7 @@ if SOUTHBRIDGE_INTEL_LYNXPOINT config SOUTH_BRIDGE_OPTIONS # dummy def_bool y + select SOUTHBRIDGE_INTEL_COMMON select IOAPIC select HAVE_HARD_RESET select HAVE_USBDEBUG diff --git a/src/southbridge/intel/sch/Kconfig b/src/southbridge/intel/sch/Kconfig index b106dd1..432fb8d 100644 --- a/src/southbridge/intel/sch/Kconfig +++ b/src/southbridge/intel/sch/Kconfig @@ -19,6 +19,7 @@ config SOUTHBRIDGE_INTEL_SCH bool + select SOUTHBRIDGE_INTEL_COMMON select HAVE_USBDEBUG select HAVE_HARD_RESET select HAVE_SMI_HANDLER

1 0