[SerialICE] New patch to review for serialice: Cleanup on walk_pre_hooks
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Fri Jun 3 17:54:56 CEST 2016
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15060
-gerrit
commit fd7f712f743dc079ecda45c2cb3e82053ab18931
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Fri Jun 3 14:32:41 2016 +0300
Cleanup on walk_pre_hooks
Variable name was misleading, we do not log operations
until post hooks.
Also no return value from this function.
Change-Id: I48106f7b74c51f82374c525d69516d7ee68aa3c0
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
SerialICE/simba/hooks.lua | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/SerialICE/simba/hooks.lua b/SerialICE/simba/hooks.lua
index 49d937c..fcb0912 100644
--- a/SerialICE/simba/hooks.lua
+++ b/SerialICE/simba/hooks.lua
@@ -80,20 +80,20 @@ prev_filter = nil
function walk_pre_hooks(list, action)
if list == nil or list.list == nil then
- return false
+ return
end
- local logged = false
+ local found = false
local l = list.list
local f = nil
- while l and not logged do
+ while l and not found do
f = l.hook
if list.match_filter(f, action) then
if f.pre and f.pre(f, action) then
if not f.raw then
action.logged_pre = f
end
- logged = true
+ found = true
end
end
l = l.next
More information about the SerialICE
mailing list