[SerialICE] New patch to review for serialice: qemu-0.15.x/serialice-com: Error on memory allocation failure

Patrick Rudolph (siro@das-labor.org) gerrit at coreboot.org
Mon Apr 25 19:25:25 CEST 2016


Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14511

-gerrit

commit 1a14a31123ce6a2e76cd803fc7a5bc3e12370431
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Mon Apr 25 12:25:30 2016 +0200

    qemu-0.15.x/serialice-com: Error on memory allocation failure
    
    Exit on memory allocation error.
    
    Change-Id: Ia72b12e974f84d157fcb64fd5c223d848b31521a
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 qemu-0.15.x/serialice-com.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/qemu-0.15.x/serialice-com.c b/qemu-0.15.x/serialice-com.c
index cb3794c..25ccaf5 100644
--- a/qemu-0.15.x/serialice-com.c
+++ b/qemu-0.15.x/serialice-com.c
@@ -195,6 +195,10 @@ const SerialICE_target *serialice_serial_init(void)
 {
     s = mallocz(sizeof(SerialICEState));
 
+    if (!s) {
+        printf("Out of memory.\n");
+        exit(1);
+    }
     if (serialice_device == NULL) {
         printf("You need to specify a serial device to use SerialICE.\n");
         exit(1);
@@ -264,7 +268,10 @@ const SerialICE_target *serialice_serial_init(void)
 
     s->buffer = mallocz(BUFFER_SIZE);
     s->command = mallocz(BUFFER_SIZE);
-
+    if (!s->buffer || !s->command) {
+        printf("Out of memory.\n");
+        exit(1);
+    }
     printf("SerialICE: Waiting for handshake with target... ");
 
     handshake_mode = 1;         // Readback errors are to be expected in this phase.



More information about the SerialICE mailing list