[SerialICE] New patch to review for serialice: d22929f smbus: ignore the least significant f.host.slave bit

Lubomir Rintel (lkundrak@v3.sk) gerrit at coreboot.org
Wed May 27 22:34:29 CEST 2015


Lubomir Rintel (lkundrak at v3.sk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10325

-gerrit

commit d22929f77f45fe795f425c6c460850d15816725e
Author: Lubomir Rintel <lkundrak at v3.sk>
Date:   Mon May 25 07:46:37 2015 +0200

    smbus: ignore the least significant f.host.slave bit
    
    It's the transaction direction.
    
    lua: chipset/smbus_host.lua:155: bad argument #2 to 'format' (number has
    no integer representation)
    stack traceback:
    	[C]: in function 'string.format'
    	chipset/smbus_host.lua:155: in upvalue 'dump_transaction'
    	chipset/smbus_host.lua:271: in upvalue 'host_change_state'
    	chipset/smbus_host.lua:288: in upvalue 'host_switch'
    	chipset/smbus_host.lua:368: in upvalue 'host_sync'
    	chipset/smbus_host.lua:445: in field 'data_read'
    	chipset/smbus_host.lua:511: in field 'update_register'
    	chipset/intel_smbus.lua:195: in upvalue 'intel_smbus_host_access'
    	chipset/intel_smbus.lua:232: in function 'intel_smbus_host_post'
    	hooks.lua:122: in function 'walk_post_hooks'
    	replay.lua:24: in function 'replay_io'
    	replay.lua:76: in function 'parse_io'
    	replay.lua:250: in function 'parse_file'
    	replay.lua:269: in main chunk
    	[C]: in ?
    
    Change-Id: Ia482fc745060c0f84f8147912bf0123d81f3f893
    Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
---
 SerialICE/simba/chipset/smbus_host.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SerialICE/simba/chipset/smbus_host.lua b/SerialICE/simba/chipset/smbus_host.lua
index f8baf2e..13049cc 100644
--- a/SerialICE/simba/chipset/smbus_host.lua
+++ b/SerialICE/simba/chipset/smbus_host.lua
@@ -152,7 +152,7 @@ local function dump_transaction(f, action)
 	end
 
 
-	local dump = string.format("%02x %s ", f.host.slave / 2, proto_name[f.host.proto])
+	local dump = string.format("%02x %s ", f.host.slave >> 1, proto_name[f.host.proto])
 
 	if host_proto(f, SMBUS_QUICK) then
 



More information about the SerialICE mailing list