[SerialICE] New patch to review for serialice: Fixed bug with formatting long integers, now zero padded instead of space padded.

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Sat Aug 15 16:13:12 CEST 2015


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11241

-gerrit

commit bc37845299ba96fc1ac798839b2de073c9b563b0
Author: Damien Zammit <damien at zamaudio.com>
Date:   Sun Aug 16 00:00:16 2015 +1000

    Fixed bug with formatting long integers, now zero padded
    instead of space padded.
    
    Change-Id: Iacb192532ea422ce8adeb89f0c141e7a9e8117ae
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 SerialICE/simba/hooks.lua  | 2 ++
 SerialICE/simba/output.lua | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/SerialICE/simba/hooks.lua b/SerialICE/simba/hooks.lua
index b69c77a..49d937c 100644
--- a/SerialICE/simba/hooks.lua
+++ b/SerialICE/simba/hooks.lua
@@ -235,6 +235,8 @@ function pre_action(action, dir_wr, addr, size, data)
 			action.data = (0xffff & data)
 		elseif size == 4 then
 			action.data = (0xffffffff & data)
+		elseif size == 8 then
+			action.data = (0xffffffffffffffff & data)
 		end
 	end
 end
diff --git a/SerialICE/simba/output.lua b/SerialICE/simba/output.lua
index 889dcc1..05b73b7 100644
--- a/SerialICE/simba/output.lua
+++ b/SerialICE/simba/output.lua
@@ -112,8 +112,8 @@ function size_data(size, data)
 	if     size == 1 then return string.format("%02x", data)
 	elseif size == 2 then return string.format("%04x", data)
 	elseif size == 4 then return string.format("%08x", data)
-	elseif size == 8 then return string.format("%16x", data)
-	else return string.format("Error: size=%x", size)
+	elseif size == 8 then return string.format("%016x", data)
+	else return string.format("Error: size=%d", size)
 	end
 end
 



More information about the SerialICE mailing list