[SerialICE] Patch set updated for serialice: 269fad7 SerialICE: Fix sio_putstring discarding 'const' qualifier.

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Fri Feb 14 14:05:21 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5223

-gerrit

commit 269fad7d56bc8638d97243359c46dcde26d67ce7
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Feb 14 21:33:10 2014 +1100

    SerialICE: Fix sio_putstring discarding 'const' qualifier.
    
    In serialice.c the function 'serialice_mainboard()' passes the argument
    'const char *' to the function 'sio_putstring()'. However it discards
    'const' qualifier from pointer target type.
    
    In file included from serialice.c:29:0:
    serial.c:85:13: note: expected 'char *' but argument is of type 'const char *'
    
    Change-Id: I144173d7d13098f0e5115a2ec92b4aa20fcec5bc
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 SerialICE/serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SerialICE/serial.c b/SerialICE/serial.c
index 204eb07..9188deb 100644
--- a/SerialICE/serial.c
+++ b/SerialICE/serial.c
@@ -82,7 +82,7 @@ static u8 sio_getc(void)
 
 /* SIO helpers */
 
-static void sio_putstring(char *string)
+static void sio_putstring(const char *string)
 {
 	/* Very simple, no %d, %x etc. */
 	while (*string) {



More information about the SerialICE mailing list