[SerialICE] New patch to review for serialice: 32d7438 Fix flag combinations

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed Mar 6 20:21:32 CET 2013


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2595

-gerrit

commit 32d7438bc4086c2a120b4b429a7e6c471d65072b
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Mar 6 19:53:09 2013 +0200

    Fix flag combinations
    
    In some rare case writes go to both hardware and qemu,
    so put those at different columns.
    
    Only one of "Undefined, Dropped or Faked" is possible
    at a time, place them on same column.
    
    Change-Id: I9b891e44ca1f044c68c21021599fa3a0f8dbae9e
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 SerialICE/simba/output.lua | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/SerialICE/simba/output.lua b/SerialICE/simba/output.lua
index a01e074..10977ea 100644
--- a/SerialICE/simba/output.lua
+++ b/SerialICE/simba/output.lua
@@ -21,17 +21,17 @@ function printk(f, action, fmt, ...)
 	end
 	if action.to_hw then
 		str = str .. "H"
-	elseif action.to_qemu then
-		str = str .. "Q"
 	else
 		str = str .. "."
 	end
-	if action.undefined then
-		str = str .. "U"
+	if action.to_qemu then
+		str = str .. "Q"
 	else
 		str = str .. "."
 	end
-	if action.dropped then
+	if action.undefined then
+		str = str .. "U"
+	elseif action.dropped then
 		str = str .. "D"
 	elseif action.faked then
 		str = str .. "F"



More information about the SerialICE mailing list