[SerialICE] New system board

Peter Stuge peter at stuge.se
Sat Jun 2 13:15:44 CEST 2012


Hi,

Beata Graff av dalHagen wrote:
> Patch to add support for Intel desktop board D945GNT. Compiled,
> flashed, booted to SerialICE prompt.

Nice! Questions:


> @@ -97,6 +100,7 @@
>  	default "kontron_986lcd-m.c" if BOARD_KONTRON_986LCD_M
>  	default "roda_rk886ex.c" if BOARD_RODA_RK886EX
>  	default "intel_d945gclf.c" if BOARD_INTEL_D945GCLF
> +	default "intel_d945gnt.c" if BOARD_INTEL_D945GNT

How different is D945GNT from D945GCLF?


> +++ mainboard/intel_d945gnt.c	(revision 0)
> @@ -0,0 +1,92 @@
> +/*
> + * SerialICE 
> + *
> + * Copyright (C) 2009 coresystems GmbH

Did you change something from the GCLF code so that you should add a
copyright claim?

If not, meaning that the two boards are quite similar, then perhaps
you can extend the code for D945GCLF, so that it works also for the
D945GNT board? (How it looks in Kconfig is another matter, either add
another line, or simply change the comment for the D945GCLF option.)


//Peter



More information about the SerialICE mailing list