<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hello Stef,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I'm using coreboot on an ASUS KGPE-D16 motherboard with <span>2x HID keyboards and 1x HID mouse</span>.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Just tested your patch and it works but I have one suggestion.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Here's a breakdown of the test results with and without your patch when all of my USB devices are connected:<br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">- Without the patch: No keyboard input during boot.</p>
<p style="margin-top:0;margin-bottom:0">- With patch and <span>CONFIG_NUM_USB_KEYBOARD=1: No keyboard input during boot. (same issue as without the patch.)</span></p>
<p style="margin-top:0;margin-bottom:0"><span>- With patch and <span>CONFIG_NUM_USB_KEYBOARD=3</span>: Can use both keyboards for input.</span></p>
<p style="margin-top:0;margin-bottom:0"><span><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span>Haven't tested with =2 but there aren't any issues with 3.<br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span>The suggestion I have is to remove the
<span><span>CONFIG_NUM_USB_KEYBOARD</span></span> / <span><span>CONFIG_NUM_USB_MOUSE options you've added and just try to scan all connected USB devices.</span></span></span></p>
<p style="margin-top:0;margin-bottom:0"><span><span><span>Haven't taken a look at the code but I could give it a shot unless you have an idea about how to do it.</span></span></span><br>
</p>
<br>
<p style="margin-top:0;margin-bottom:0">Hope this information helped. Attached my generated config.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Regards,</p>
<p style="margin-top:0;margin-bottom:0">- Daniel K.<br>
</p>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Stef van Os <stef.van.os@prodrive-technologies.com><br>
<b>Sent:</b> 21 December 2017 06:13<br>
<b>To:</b> Daniel K; Kevin O'Connor<br>
<b>Cc:</b> seabios@seabios.org<br>
<b>Subject:</b> Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Daniel,<br>
<br>
Is this a problem with the patch applied? It was tested on our hardware <br>
to function.<br>
<br>
Some questions:<br>
* What hardware platform are you using?<br>
* Does the numeric keyboard work if it is the only keyboard (or if you <br>
swap ports, which hopefully changes enumeration order) in the system, <br>
maybe the problem is elsewhere and was masked because the (normal) <br>
keyboard was enumerated first and the second (numeric) was ignored earlier.<br>
<br>
Also, the patch can be verified using qemu and two vnc inputs:<br>
<br>
qemu-system-x86_64 -m 4096 -M q35 -smp 8 \<br>
-pflash bios.qemu.rom \<br>
-drive format=raw,file=disk.img \<br>
-device pci-bridge,addr=12.0,chassis_nr=2,id=head.2 \<br>
-device nec-usb-xhci,bus=head.2,addr=0f.0,id=usb.2 \<br>
-device VGA,id=video.1 \<br>
-device secondary-vga,bus=head.2,addr=02.0,id=video.2 \<br>
-display vnc=:15,id=primary,display=video.1 \<br>
-display vnc=:16,id=secondary,display=video.2 \<br>
-usb \<br>
-device usb-kbd,bus=usb.2.0,port=1,display=video.1 \<br>
-device usb-kbd,bus=usb.2.0,port=2,display=video.2 \<br>
-serial stdio<br>
<br>
Best regards,<br>
Stef<br>
<br>
<br>
<br>
On 12/20/2017 06:20 PM, Daniel K wrote:<br>
> When I have more than 2 usb keyboards connected, SeaBIOS doesn't register keyboard input.<br>
> This persists even when I get to the disk GRUB menu.<br>
> I have to manually unplug my other keyboard to do any input during boot.<br>
> <br>
> And by other keyboard, I just mean a separate numerical keypad.<br>
> <br>
>> From: SeaBIOS <seabios-bounces@seabios.org> on behalf of Kevin O'Connor <kevin@koconnor.net><br>
>> Sent: 20 December 2017 08:33<br>
>> To: Stef van Os<br>
>> Cc: seabios@seabios.org<br>
>> Subject: Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support<br>
>><br>
>> On Fri, Dec 15, 2017 at 11:09:45AM +0100, Stef van Os wrote:<br>
>>> The following patch adds support for multiple usb keyboards and mice to seabios.<br>
>>> Maximum number of keyboards is configurable in Kconfig and defaults to 1 to keep<br>
>>> current behavior.<br>
>><br>
>> Thanks. What's the use case for enabling multiple keyboards?<br>
>><br>
>> -Kevin<br>
> <br>
> <br>
> <br>
> <br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>