[SeaBIOS] [PATCH v2 1/3] tpm: Wait for tpmRegValidSts flag on CRQ interface before probing

Stefan Berger stefanb at linux.vnet.ibm.com
Wed Mar 21 17:57:19 CET 2018


On 03/21/2018 10:38 AM, Kevin O'Connor wrote:
> On Mon, Mar 19, 2018 at 12:23:10PM -0400, Stephen Douthit wrote:
>> On 03/19/2018 12:00 PM, Stefan Berger wrote:
>>> Wait for the tpmRegValidSts flag on the TPM_LOC_STATE_x register to
>>> be set; we espect the locAssigned flag to not be set.
>> s/espect/expect/ and in the subject line s/CRQ/CRB
>>
>> Just retested the v2 series on my board so:
>> Tested-by: Stephen Douthit <stephend at silicom-usa.com>
> Thanks.  I committed this series.
>
> Does this resolve the pause at startup for non-TPM users?

It should. I removed that write() statement you commented on and that 
was necessary to run before the read() due to an implementation mistake 
in QEMU. Maybe Paul can confirm with the latest tip.

    Stefan

>
> -Kevin
>




More information about the SeaBIOS mailing list