[SeaBIOS] [PATCH v2 0/6] Fixes for physical presence and API

Stefan Berger stefanb at us.ibm.com
Thu Jan 7 17:52:50 CET 2016


"Kevin O'Connor" <kevin at koconnor.net> wrote on 01/07/2016 11:19:30 AM:

> 
> On Thu, Jan 07, 2016 at 07:55:35AM -0500, Stefan Berger wrote:
> > Patch 1 fixes the return of a missing digest in the 
> HashLogExtendEvent command.
> > 
> > Beyond thad that, the patches extend the handling of physical presence 
to HW
> > physical presence and rework the showing of the TPM menu to dependon 
whether
> > SW physical presence could be asserted or HW physical presence hasbeen 
found
> > to be enabled.
> 
> Thanks.  In general it looks good to me.  However, it looks like you
> applied your patches on top of my testing branch instead of on top of
> the master branch.  My testing branch diverged from master (I didn't
> apply patch 8, and I fixed a couple of typos before committing to
> master).
> 
> I merged your patches into master and put them back to the (now
> updated) testing branch:
>   https://github.com/KevinOConnor/seabios/tree/testing
> 
> Also, each patch in the series should have "tpm: " prefaced to the
> subject and I have three comments in patches 4 and 5.  They are minor,
> so I can fix these on commit if you wish - let me know.

I can post a v3 based on the new ones in testing.

   Stefan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.seabios.org/pipermail/seabios/attachments/20160107/af589f9b/attachment.html>


More information about the SeaBIOS mailing list