[SeaBIOS] [PATCH 1/6] remove iasl-generated hex files from git repo

Gerd Hoffmann kraxel at redhat.com
Tue May 22 11:50:37 CEST 2012


On 05/18/12 05:16, Kevin O'Connor wrote:
> On Tue, May 15, 2012 at 12:46:21PM +0200, Gerd Hoffmann wrote:
>> Almost every linux distro has iasl packaged these days.
>> Lets make it a build dependency and stop the hassle we
>> have with updating the *.hex files in the git repo.
> 
> I'm a bit torn on this.  I see the gain in that it simplifies the
> build and makes patches smaller.

Patch conflicts in the generated files are a pain too.

>  It also allows include files (eg,
> config.h) to be pulled into the asl code so that symbolic names can be
> shared.  Iasl is easily available from most distros, but it isn't
> installed by default.  I don't want to scare off any casual users that
> download the git tree and attempt to compile.

We can detect iasl and print a friendly message in case it isn't there,
see attached patch.  Comments?

And, yes, we probably want move them to out/ as suggested by Marc in
case we'll go that route.

cheers,
  Gerd
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-iasl-detection.patch
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120522/e03838ea/attachment-0001.ksh>


More information about the SeaBIOS mailing list