<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thank you for your answer David, I will follow your hint!</p>
<p><br>
</p>
<pre class="moz-signature" cols="72">Best regards,
Miklos Marton</pre>
<div class="moz-cite-prefix">2018-01-30 22:54 keltezéssel, David
Hendricks írta:<br>
</div>
<blockquote type="cite"
cite="mid:MWHPR15MB1776A047047231184E5B4599B2E40@MWHPR15MB1776.namprd15.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Arial,Helvetica,sans-serif;"
dir="ltr">
<div id="divtagdefaultwrapper" style="font-size: 12pt; color:
rgb(0, 0, 0); font-family: Arial, Helvetica, sans-serif,
EmojiFont, "Apple Color Emoji", "Segoe UI
Emoji", NotoColorEmoji, "Segoe UI Symbol",
"Android Emoji", EmojiSymbols;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Miklos,</p>
<p style="margin-top:0;margin-bottom:0">Yes, coreboot's gerrit
system is likely where the review will take place. The
github repository is a mirror of coreboot's flashrom
repository, however we recognize that a lot of people do
development on github so we work with pull requests as well.
We also still have patch submissions via e-mail.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">You may receive
comments to your pull request on github, however if the
patch is small enough (like PR33) then it might just be sent
directly to review.coreboot.org for final review before
being merged and ultimately mirrored in the github repo.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">As usual the
bottleneck is the amount of spare time reviewers have and
we've been juggling some large changes lately. We do
appreciate the contributions, and please feel free to nudge
us if there is urgency or if things simply linger for too
long.</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
color="#000000" face="Calibri, sans-serif"><b>From:</b>
flashrom <a class="moz-txt-link-rfc2396E" href="mailto:flashrom-bounces@flashrom.org"><flashrom-bounces@flashrom.org></a> on behalf of
Miklos Marton <a class="moz-txt-link-rfc2396E" href="mailto:martonmiklosqdev@gmail.com"><martonmiklosqdev@gmail.com></a><br>
<b>Sent:</b> Tuesday, January 30, 2018 12:47:44 PM<br>
<b>To:</b> flashrom<br>
<b>Subject:</b> [flashrom] Github PRs</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span
style="font-size:11pt;">
<div class="PlainText">Hello flashrom developers!<br>
<br>
I have submitted two PRs to github (as the wiki mentions
it is also a <br>
possible contribution channel).<br>
<br>
Do I need to do anything else with that? I am not
intended to seems to <br>
be impatient I just would like to make sure that
everything is in place <br>
(this is my first contribution to flashrom this way).<br>
<br>
If I remember correctly the coreboot gerrit was used to
do code review. <br>
Is it going to be moved there or we will perform the
code review at the <br>
github?<br>
<br>
-- <br>
Best regards,<br>
Miklos Marton<br>
<br>
<br>
_______________________________________________<br>
flashrom mailing list<br>
<a class="moz-txt-link-abbreviated" href="mailto:flashrom@flashrom.org">flashrom@flashrom.org</a><br>
<a
href="https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.coreboot.org_mailman_listinfo_flashrom&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=CFWWReJabtqA8oU7yaBHbIE9YvsZmeYWXWpJOiuGyNM&m=5TRHJNBzy4Ly4wu_seBtgMrm4lLIHJEwJ9sFPAyQ3Ak&s=iU6v_NcdY8-R_kO427ws-_UchWm5UZ692qxfiE_Xl90&e="
id="LPlnk256244" previewremoved="true"
moz-do-not-send="true">https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.coreboot.org_mailman_listinfo_flashrom&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=CFWWReJabtqA8oU7yaBHbIE9YvsZmeYWXWpJOiuGyNM&m=5TRHJNBzy4Ly4wu_seBtgMrm4lLIHJEwJ9sFPAyQ3Ak&s=iU6v_NcdY8-R_kO427ws-_UchWm5UZ692qxfiE_Xl90&e=</a><br>
</div>
</span></font></div>
</div>
</blockquote>
<br>
</body>
</html>