<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Arial,Helvetica,sans-serif;" dir="ltr">
<p><span style="font-size: 10pt;">Hi Sandy,</span></p>
<p><span style="font-size: 10pt;"><span style="font-size: 10pt;">I updated the flashrom code to
</span><span style="font-size: 10pt;">better take into account differences with Lewisburg, including the number of FREG</span><span style="font-size: 10pt;"> registers as you point out: </span><a href="https://review.coreboot.org/#/c/20922/" class="OWAAutoLink" id="LPlnk461133" previewremoved="true"><span style="font-size: 10pt;">https://review.coreboot.org/#/c/20922/</span></a></span><br>
</p>
<p><br>
</p>
<p><span style="font-size: 10pt;">When you have a chance, please and try again (using -V). You can copy+paste your result here for convenience: <a href="https://paste.flashrom.org/" class="OWAAutoLink" id="LPlnk916598" previewremoved="true">https://paste.flashrom.org/</a>.</span></p>
<div id="LPBorder_GT_15042984126090.3376301165161959" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;">
<table id="LPContainer_15042984125930.8367678377675081" role="presentation" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);">
<tbody>
<tr valign="top" style="border-spacing: 0px;">
<td id="TextCell_15042984125980.762936615478599" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;">
<div id="LPRemovePreviewContainer_15042984125990.3443368167805798"></div>
<div id="LPTitle_15042984125990.018054182024593635" style="top: 0px; color: rgb(0, 120, 215); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;">
<a id="LPUrlAnchor_15042984126020.7247129730303055" href="https://paste.flashrom.org/" target="_blank" style="text-decoration: none;">Flashrom -- File upload serivce</a></div>
<div id="LPMetadata_15042984126030.348205555819493" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;">
paste.flashrom.org</div>
<div id="LPDescription_15042984126060.11437541320302125" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;">
Welcome to flashrom's file upload service Please post only flashrom/coreboot/seabios or other firmware related contents. Post a new paste You can either post text ...</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<p></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> flashrom <flashrom-bounces@flashrom.org> on behalf of Sandy Zhang <sanzhang@celestica.com><br>
<b>Sent:</b> Monday, August 14, 2017 4:36:00 AM<br>
<b>To:</b> David Hendricks<br>
<b>Cc:</b> flashrom@flashrom.org<br>
<b>Subject:</b> Re: [flashrom] When flashrom support Intel Purley platform Lewisburg PCH?</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi David,
<div><br>
</div>
<div>Lewisburg PCH defines sixty SPI regions, but from the code in ichspi.c, I find it defines only 10 regions, is this the reason about only 10 regions was described in the log file?</div>
<div><br>
</div>
<div>code as below: (num_freg define the spi regions)</div>
<div><br>
</div>
<div>int ich_init_spi(void *spibar, enum ich_chipset ich_gen)</div>
<div>{</div>
<div><span style="white-space:pre"></span>...</div>
<div> ...</div>
<div> ...</div>
<div><span style="white-space:pre"></span>/* Moving registers / bits */</div>
<div><span style="white-space:pre"></span>if (ich_generation == CHIPSET_100_SERIES_SUNRISE_POINT) {</div>
<div><span style="white-space:pre"></span><font color="#0000ff">num_freg<span style="white-space:pre">
</span>= 10;</font></div>
<div><span style="white-space:pre"></span>num_pr<span style="white-space:pre"> </span>
= 6;</div>
<div><span style="white-space:pre"></span>reg_pr0<span style="white-space:pre"> </span>
= PCH100_REG_FPR0;</div>
<div><span style="white-space:pre"></span>swseq_data.reg_ssfsc<span style="white-space:pre">
</span>= PCH100_REG_SSFSC;</div>
<div><span style="white-space:pre"></span>swseq_data.reg_preop<span style="white-space:pre">
</span>= PCH100_REG_PREOP;</div>
<div><span style="white-space:pre"></span>swseq_data.reg_optype<span style="white-space:pre">
</span>= PCH100_REG_OPTYPE;</div>
<div><span style="white-space:pre"></span>swseq_data.reg_opmenu<span style="white-space:pre">
</span>= PCH100_REG_OPMENU;</div>
<div><span style="white-space:pre"></span>hwseq_data.addr_mask<span style="white-space:pre">
</span>= PCH100_FADDR_FLA;</div>
<div><span style="white-space:pre"></span>hwseq_data.only_4k<span style="white-space:pre">
</span>= true;</div>
<div><span style="white-space:pre"></span>hwseq_data.hsfc_fcycle<span style="white-space:pre">
</span>= PCH100_HSFC_FCYCLE;</div>
<div><span style="white-space:pre"></span>} </div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-08-14 14:23 GMT+08:00 David Hendricks <span dir="ltr">
<<a href="mailto:david.hendricks@gmail.com" target="_blank">david.hendricks@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra">On Sun, Aug 13, 2017 at 6:26 PM, Sandy Zhang <span dir="ltr">
<<a href="mailto:sanzhang@celestica.com" target="_blank">sanzhang@celestica.com</a>></span> wrote:<br>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi David,
<div><br>
</div>
<div>I'm inline.</div>
</div>
</blockquote>
<div><br>
</div>
<div>I don't see your responses. Did you intend to reply to my comments?</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra">
<div>
<div class="m_8669563924535158350h5"><br>
<div class="gmail_quote">2017-08-14 9:17 GMT+08:00 David Hendricks <span dir="ltr">
<<a href="mailto:david.hendricks@gmail.com" target="_blank">david.hendricks@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi Sandy,
<div><br>
</div>
<div>Responses in-line.</div>
<div><br>
</div>
<div class="gmail_extra">
<div class="gmail_quote">On Fri, Aug 11, 2017 at 1:38 AM, Sandy Zhang <span dir="ltr">
<<a href="mailto:sanzhang@celestica.com" target="_blank">sanzhang@celestica.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Hi David,
<div><br>
</div>
<div> Sorry, I have a doubt about the range outside, from the binary map, we can find the Spare 3 Region size is 0x00FFFFFF - 0xFF0000 + 1 = 0x10000, and the binary size map to this range is also 0x10000, they are equal, why outside was happened? and can
you tell me how to update the binary region's range defined in the flash description?</div>
<div><br>
</div>
<div>
<div>Start (hex) End (hex) Length (hex) Area Name</div>
<div>----------- --------- ------------ ---------</div>
<div>...</div>
<div>...</div>
<div>....</div>
<div><font color="#0000ff">00FF0000 00FFFFFF 00010000 Spare 3 Region</font></div>
<div>01000000 01FFFFFF 01000000 BIOS Region</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>The Flash Region registers (BIOS_FREGn) define the boundaries of each region. I don't see where 0xa36000-0xffffff is covered:</div>
<div>0x54: 0x00000000 FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-write.</div>
<div>0x58: 0x1fff1000 FREG1: BIOS region (0x01000000-0x01ffffff) is read-write.</div>
<div>0x5C: 0x0a250003 FREG2: Management Engine region (0x00003000-0x00a25fff) is read-write.</div>
<div>0x60: 0x00020001 FREG3: Gigabit Ethernet region (0x00001000-0x00002fff) is read-write.</div>
<div>0x64: 0x00007fff FREG4: Platform Data region is unused.</div>
<div>0x68: 0x0a350a26 FREG5: unknown region (0x00a26000-0x00a35fff) is read-write.</div>
<div>0x6C: 0x00007fff FREG6: unknown region is unused.</div>
<div>0x70: 0x00007fff FREG7: unknown region is unused.</div>
<div>0x74: 0x00007fff FREG8: unknown region is unused.</div>
<div>0x78: 0x00007fff FREG9: unknown region is unused.</div>
<div><br>
</div>
<div>You might also need to set permissions for the "BIOS" master (i.e. flashrom running on the CPU) via BRWA and BRRA in the FRACC register.</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div> In addition, from flash log file(please see attachment "Lewisburg_W25Q256.log"), it shows:<br>
</div>
<div><font color="#0000ff">Found Programmer flash chip "Opaque flash chip" (32768 kB, Programmer-specific) mapped at physical address 0x0000000000000000.</font></div>
<div> but, my flash chip is "Winbond flash chip", what do you think about this? </div>
</div>
</blockquote>
<div><br>
</div>
<div>This is OK. Intel hardware sequencing is an "opaque" programmer interface since flashrom does not directly send NOR flash commands via a raw SPI interface. For hardware sequencing we use the FCYCLE field as our command interface to the SPI flash.</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<span class="HOEnZb"><font color="#888888">
<div><br>
</div>
</font></span></div>
</div>
<span class="HOEnZb"><font color="#888888"><span>-- <br>
<div class="m_8669563924535158350m_9190629963634972489gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr"><br>
<div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Best Regard!</font></b></div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif"><br>
</font></b></div>
<div><font color="#0c343d" face="arial, helvetica, sans-serif"><b>Sandy Zhang (</b> ÕÅÁ¢¿µ<b>)</b></font></div>
<b><font color="#0c343d" face="arial, helvetica, sans-serif">BIOS Engineer</font></b>
<div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Global Design Service</font></b></div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Celestica(Shanghai) R&D Center, China</font></b></div>
</div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Mail: sanzhang<a href="mailto:viterzho@celestica.com" style="color:rgb(17,85,204)" target="_blank">@celestica.com</a></font></b></div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Mobile: <a href="tel:+86%20159%206535%203952" value="+8615965353952" target="_blank">
(+86)15965353952</a></font></b></div>
</div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Phone: (+86)021-61006028-7623</font></b><b><font color="#0c343d" face="arial, helvetica, sans-serif"><br>
</font></b></div>
</div>
</div>
</div>
</div>
</div>
</div>
</span></font></span></div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr"><br>
<div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Best Regard!</font></b></div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif"><br>
</font></b></div>
<div><font color="#0c343d" face="arial, helvetica, sans-serif"><b>Sandy Zhang (</b> ÕÅÁ¢¿µ<b>)</b></font></div>
<b><font color="#0c343d" face="arial, helvetica, sans-serif">BIOS Engineer</font></b>
<div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Global Design Service</font></b></div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Celestica(Shanghai) R&D Center, China</font></b></div>
</div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Mail: sanzhang<a href="mailto:viterzho@celestica.com" style="color:rgb(17,85,204)" target="_blank">@celestica.com</a></font></b></div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Mobile: (+86)15965353952</font></b></div>
</div>
<div><b><font color="#0c343d" face="arial, helvetica, sans-serif">Phone: (+86)021-61006028-7623</font></b><b><font color="#0c343d" face="arial, helvetica, sans-serif"><br>
</font></b></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>