<div dir="ltr"><div>commit 9fe248fb removes the use of addr and reg variable in this function, that's why this code doesn't compile with <span class="gmail-im"><span>CONFIG_DEBUG_RAM_SETUP</span></span>.</div><div>I've submitted a fix for this: <a href="https://review.coreboot.org/#/c/coreboot/+/28117/">https://review.coreboot.org/#/c/coreboot/+/28117/</a></div><div>or remove the printram statement?<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 16, 2018 at 4:27 PM, Andreas Restle <span dir="ltr"><<a href="mailto:andreas.restle@gmail.com" target="_blank">andreas.restle@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Hi Nico,<div><br></div><div>thanks for the quick reply. If it’s on, it must have been by accident. I’ll check later today and report back. </div><div><br></div><div>Building with the same .config worked fine two weeks ago though. But your last sentence probably is an explanation for that.<br><br><div><div><div><p class="MsoNormal" style="margin:0cm 0cm 0.0001pt"><span style="background-color:rgba(255,255,255,0)">Viele Grüße<span class="HOEnZb"><font color="#888888"><u></u><u></u></font></span></span></p></div><span class="HOEnZb"><font color="#888888"><p class="MsoNormal" style="margin:0cm 0cm 0.0001pt"><span style="background-color:rgba(255,255,255,0)">Andreas Restle<u></u><u></u></span></p></font></span></div><span class=""><div><p class="MsoNormal" style="margin:0cm 0cm 0.0001pt"><span style="background-color:rgba(255,255,255,0)"><br clear="all"><u></u><u></u></span></p><div><p class="MsoNormal" style="margin:0cm 0cm 0.0001pt"><span style="background-color:rgba(255,255,255,0)">--<br><°)))><<br>Andreas Restle<br><a href="mailto:andreas.restle@gmail.com" target="_blank">andreas.restle@gmail.com</a></span></p></div></div></span></div><span class=""><div><br>On 16. Aug 2018, at 10:10, Nico Huber <<a href="mailto:nico.h@gmx.de" target="_blank">nico.h@gmx.de</a>> wrote:<br><br></div><blockquote type="cite"><div><span>Hi Andreas,</span><br><span></span><br><span>On 16.08.2018 08:25, Andreas Restle wrote:</span><br><blockquote type="cite"><span>Building coreboot for Thinkpad W520 currently fails with the following</span><br></blockquote><blockquote type="cite"><span>error:</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>    CC         romstage/northbridge/<wbr>intel/sandybridge/raminit_<wbr>common.o</span><br></blockquote><blockquote type="cite"><span>In file included from src/northbridge/intel/<wbr>sandybridge/raminit_common.c:<wbr>18:</span><br></blockquote><blockquote type="cite"><span>src/northbridge/intel/<wbr>sandybridge/raminit_common.c: In function</span><br></blockquote><blockquote type="cite"><span>'dram_odt_stretch':</span><br></blockquote><blockquote type="cite"><span>src/northbridge/intel/<wbr>sandybridge/raminit_common.c:<wbr>211:49: error: 'reg'</span><br></blockquote><blockquote type="cite"><span>undeclared (first use in this function); did you mean 'prog'?</span><br></blockquote><blockquote type="cite"><span>   printram("OTHP Workaround [%x] = %x\n", addr, reg);</span><br></blockquote><span></span><br><span>it seems you have CONFIG_DEBUG_RAM_SETUP enabled. This is really only</span><br><span>for debugging and nothing for end users / production builds. Debugging</span><br><span>code is often broken (even when it does compile).</span><br><span></span><br><span>Nico</span><br></div></blockquote></span></div></div><br>-- <br>
coreboot mailing list: <a href="mailto:coreboot@coreboot.org">coreboot@coreboot.org</a><br>
<a href="https://mail.coreboot.org/mailman/listinfo/coreboot" rel="noreferrer" target="_blank">https://mail.coreboot.org/<wbr>mailman/listinfo/coreboot</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>My website: <a href="https://vimacs.lcpu.club" target="_blank">https://vimacs.lcpu.club</a><br></div><div dir="ltr"><br></div><div dir="ltr">Please do not send me Microsoft Office/Apple iWork documents. Send OpenDocument instead! <a href="http://fsf.org/campaigns/opendocument/" target="_blank">http://fsf.org/campaigns/opendocument/</a></div></div></div></div>
</div>