<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Nico,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">The change you pointed do the trick!</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">How can I submit a little patch to Coreboot in order to add this change?</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"></p>
<div>--- a/src/northbridge/amd/pi/00660F01/northbridge.c 2018-05-10 09:39:18.647612837 +0200<br>
+++ b/src/northbridge/amd/pi/00660F01/northbridge.c 2018-07-03 07:56:12.794972857 +0200<br>
@@ -796,12 +796,21 @@<br>
}<br>
}<br>
<br>
+static const char *domain_acpi_name(const struct device *dev)<br>
+{<br>
+ if (dev->path.type == DEVICE_PATH_DOMAIN)<br>
+ return "PCI0";<br>
+<br>
+ return NULL;<br>
+}<br>
+<br>
static struct device_operations pci_domain_ops = {<br>
.read_resources = domain_read_resources,<br>
.set_resources = domain_set_resources,<br>
.enable_resources = domain_enable_resources,<br>
.init = NULL,<br>
.scan_bus = pci_domain_scan_bus,<br>
+ .acpi_name = domain_acpi_name,<br>
};<br>
<br>
static void sysconf_init(device_t dev) // first node</div>
<br>
<p></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>De:</b> Nico Huber <nico.h@gmx.de><br>
<b>Enviado:</b> viernes, 29 de junio de 2018 17:28:52<br>
<b>Para:</b> Jorge Fernandez Monteagudo; coreboot@coreboot.org; Zaolin<br>
<b>Asunto:</b> Re: [coreboot] RV: Error booting with TPM enabled.</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi,<br>
<br>
On 29.06.2018 16:13, Jorge Fernandez Monteagudo wrote:<br>
> In 00730F01/northbridge.c I can see:<br>
> [...]<br>
> static struct device_operations pci_domain_ops = {<br>
> [...]<br>
> and in 00660F01/northbridge.c there is no acpi_name! The most related to the previous one is:<br>
> [...]<br>
> static struct device_operations northbridge_operations = <br>
<br>
sorry, I wrote `northbridge device` sometimes, what I really meant is<br>
the `domain device`, hence you have to add it to `pci_domain_ops` just<br>
like in the 00730F01 case.<br>
<br>
> On monday I'll try to add the method to 00660F01 code!<br>
<br>
Good luck!<br>
<br>
Nico<br>
<br>
> <br>
> ________________________________<br>
> De: Nico Huber <nico.h@gmx.de><br>
> Enviado: viernes, 29 de junio de 2018 15:47:09<br>
> Para: Jorge Fernandez Monteagudo; coreboot@coreboot.org; Zaolin<br>
> Asunto: Re: [coreboot] RV: Error booting with TPM enabled.<br>
> <br>
> On 29.06.2018 12:48, Jorge Fernandez Monteagudo wrote:<br>
>> Ok, I think I've found the problem... If I force in 'src/drivers/pc80/tpm/tis.c'<br>
>><br>
>> the path value to "\\_SB_.PCI0.LIBR" it works!<br>
>><br>
>> Now, I'll try to guess from where the "\_SB.\_SB.LIBR" current value comes from...<br>
>> but now it's working.<br>
> <br>
> This is expected if you still haven't implemented `.acpi_name` for<br>
> your northbridge device. In case you haven't tried it yet: Just copy<br>
> what `nb/amd/pi/00730F01/northbridge.c` does about `.acpi_name` to<br>
> `nb/amd/pi/00660F01/northbridge.c`.<br>
> <br>
> Again, if the domain device doesn't implement `.acpi_name`, its parent<br>
> device will be asked. And in this case the parent, the root device,<br>
> always returns `\_SB`.<br>
> <br>
> Nico<br>
> <br>
<br>
</div>
</span></font></div>
</body>
</html>