<div dir="ltr">Thanks Julien! I´ll submit a patch to Gerrit soon.<div><br></div><div>BTW, have you noticed that Linux is always showing an additional CPU in the /sys/devices/system/cpu/ folder?</div><div>Here, for a quad-core CPU I have the following:</div><div>pinelake:~ # ll /sys/devices/system/cpu/cpu*<br></div><div><div>total 0</div><div>drwxr-xr-x 9 root root 0 May 29 22:46 cpu0</div><div>drwxr-xr-x 4 root root 0 May 29 22:46 cpu1</div><div>drwxr-xr-x 9 root root 0 May 29 22:46 cpu2</div><div>drwxr-xr-x 9 root root 0 May 29 22:46 cpu3</div><div>drwxr-xr-x 9 root root 0 May 29 22:46 cpu4</div></div><div>pinelake:~ # cat /sys/devices/system/node/node0/cpumap<br></div><div><div>1d</div><div>pinelake:~ # cat /sys/devices/system/node/node0/cpulist</div><div>0,2-4</div></div><div><br></div><div>And during the Linux boot I see the following error:</div><div><div>[ 10.116007] smpboot: do_boot_cpu failed(-1) to wakeup CPU#1</div></div><div><br></div><div>Looks like the issue in my case is caused by a wrong LAPIC value for the BSP CPU in the devicetree.cb... The coreboot log shows:</div><div>IOAPIC: Bootstrap Processor Local APIC = 0x04<br></div><div>But in the devicetree.cb we have:</div><div><div><span style="white-space:pre"> </span>device cpu_cluster 0 on</div><div><span style="white-space:pre"> </span>device lapic 0 on end</div><div><span style="white-space:pre"> </span>end</div></div><div><br></div><div>If I change the lapic value from 0 to 4 then Linux is not complaining about <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">do_boot_cpu failed... and sysfs shows the correct amount of CPU´s:</span></div><div><span style="text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px">pinelake:~ # ll /sys/devices/system/cpu/cpu*<br></div><div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px;text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">total 0</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px;text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">drwxr-xr-x 9 root root 0 May 29 22:46 cpu0</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px;text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">drwxr-xr-x 4 root root 0 May 29 22:46 cpu1</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px;text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">drwxr-xr-x 9 root root 0 May 29 22:46 cpu2</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px;text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">drwxr-xr-x 9 root root 0 May 29 22:46 cpu3</div><div>linux-80my:~ # cat /sys/devices/system/node/node0/cpumap</div><div>f</div><div>linux-80my:~ # cat /sys/devices/system/node/node0/cpulist</div><div>0-3</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px"><br></div></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px">Please let me know if this happens to you and if the same fix can be applied!</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px">Thanks,</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px">Sumo</div></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-06-04 9:46 GMT-03:00 Julien Viard de Galbert <span dir="ltr"><<a href="mailto:jviarddegalbert@online.net" target="_blank">jviarddegalbert@online.net</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><span class=""><br><blockquote type="cite"><div>Le 29 mai 2018 à 16:48, Sumo <<a href="mailto:kingsumos@gmail.com" target="_blank">kingsumos@gmail.com</a>> a écrit :</div><br class="m_-4873815820642408740Apple-interchange-newline"><div><div dir="ltr">Hi,<div><br></div><div>Today denverton_core_init() is enabling the Intel SpeedStep only if turbo mode is available. As a result, the SpeedStep is not enable for the C3558 variant (and others).
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Any clues of why it was implemented this way?</span></div></div></div></blockquote><blockquote type="cite"><div><div dir="ltr"><div>I think it is safe to remove the "if (get_turbo_state() == TURBO_ENABLED)" test and always enable the SpeedStep technology.</div></div></div></blockquote><div><br></div></span><div>You are right, I also think it’s safe. (The variant I have access to have Turbo so I can’t test it).</div><div>I also have no clue, but it was like this since the first denverton commit… </div><div>So please test and submit a patch ;)</div><div><br></div><div>Best Regads</div><div>Julien</div><br><blockquote type="cite"><div><div dir="ltr"><div><br></div><div>Thanks,</div><div>Sumo</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></div>
-- <br>coreboot mailing list: <a href="mailto:coreboot@coreboot.org" target="_blank">coreboot@coreboot.org</a><br><a href="https://mail.coreboot.org/mailman/listinfo/coreboot" target="_blank">https://mail.coreboot.org/<wbr>mailman/listinfo/coreboot</a></div></blockquote></div><br><div>
<div dir="auto" style="word-wrap:break-word;line-break:after-white-space"><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">--</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Julien Viard de Galbert - <a href="mailto:jviarddegalbert@online.net" target="_blank">jviarddegalbert@online.net</a></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Online / Scaleway<br>Looking for an amazing job? Join us NOW ! <a href="https://careers.scaleway.com/" target="_blank">https://careers.scaleway.<wbr>com/</a></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><br class="m_-4873815820642408740Apple-interchange-newline"></div><br class="m_-4873815820642408740Apple-interchange-newline">
</div>
<br></div></blockquote></div><br></div>