<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi!</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Adding the dependency the code compiles ok, but nothing happens.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I've been able to get a TPM2.0 with SPI, a supported
<span>SLB9670</span>. I've added <br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"></p>
<div> select TPM2<br>
select MAINBOARD_HAS_TPM2<br>
select SPI_TPM<br>
<br>
</div>
to the Kconfig of my mainboard/amd/bettong. It compiles ok but nothing happens.
<p></p>
<p style="margin-top:0;margin-bottom:0">I've trace the initialization to tpm2:</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"><span>tlcl_lib_init</span> -> <span>tis_init</span> ->
<span>tpm2_init</span><br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">but '<span>tlcl_lib_init</span>' it seems to depend on vboot and with this AMD board no vboot is implemented.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I've tried to call tis_init from the board romstage.c :</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"></p>
<div>void agesa_postcar(struct sysinfo *cb)<br>
{<br>
post_code(0x41);<br>
AGESAWRAPPER(amdinitenv);<br>
<br>
tis_init();<br>
<br>
if (acpi_is_wakeup_s4()) {<br>
outb(0xEE, PM_INDEX);<br>
outb(0x8, PM_DATA);<br>
}<br>
}</div>
<p></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">but a linking error is show:</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"></p>
<div> LINK cbfs/fallback/romstage.debug<br>
build/romstage/drivers/spi/spi-generic.o: In function `spi_setup_slave':<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/drivers/spi/spi-generic.c:129: undefined reference to `spi_ctrlr_bus_map'<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/drivers/spi/spi-generic.c:131: undefined reference to `spi_ctrlr_bus_map_count'<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/drivers/spi/spi-generic.c:134: undefined reference to `spi_ctrlr_bus_map'<br>
build/romstage/drivers/spi/tpm/tpm.o: In function `stopwatch_tick':<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/include/timer.h:155: undefined reference to `timer_monotonic_get'<br>
build/romstage/drivers/spi/tpm/tpm.o: In function `stopwatch_init':<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/include/timer.h:131: undefined reference to `timer_monotonic_get'<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/include/timer.h:131: undefined reference to `timer_monotonic_get'<br>
/mnt/develop/bettong/coreboot/master/coreboot/src/include/timer.h:131: undefined reference to `timer_monotonic_get'<br>
make: *** [build/cbfs/fallback/romstage.debug] Error 1<br>
<br>
</div>
Any hint?
<p></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Thanks!</p>
<p style="margin-top:0;margin-bottom:0">Jorge<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>De:</b> Zaolin <zaolin@das-labor.org><br>
<b>Enviado:</b> jueves, 17 de mayo de 2018 0:08:24<br>
<b>Para:</b> Jorge Fernandez Monteagudo; coreboot@coreboot.org<br>
<b>Asunto:</b> Re: [coreboot] SPI TPM question</font>
<div> </div>
</div>
<meta content="text/html; charset=Windows-1252">
<div style="background-color:#FFFFFF">
<p>Hey,</p>
<p><br>
</p>
The SPI tpm driver was written for tpm 2.0 only.<br>
You can try to add TPM to "depends on" as well and see what happens.<br>
<br>
Let us know if it works. :)<br>
<br>
<br>
Best Regards, Philipp<br>
<br>
<div class="x_moz-cite-prefix">On 15.05.2018 19:53, Jorge Fernandez Monteagudo wrote:<br>
</div>
<blockquote type="cite"><style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0; margin-bottom:0">Hi all!</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">This is my first message to the list. I would like to know if the TPM1.2 is supported through SPI?</p>
<p style="margin-top:0; margin-bottom:0">Enabling SPI_TPM and TPM in my board configuration throw an error. From src/drivers/spi/tpm/Kconfig</p>
<p style="margin-top:0; margin-bottom:0">I can see the dependency:</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<div>config SPI_TPM<br>
bool "SPI TPM"<br>
depends on TPM2<br>
<br>
</div>
Any options to get TPM1.2 SPI support?
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">Thanks!</p>
<p style="margin-top:0; margin-bottom:0">Jorge<br>
</p>
</div>
<br>
<fieldset class="x_mimeAttachmentHeader"></fieldset> <br>
</blockquote>
<br>
</div>
</body>
</html>