<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.gmail-
{mso-style-name:gmail-;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Matt,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks for looking into this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Please submit the patch since you have identified the issue.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hannah Williams<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Matt DeVillier [mailto:matt.devillier@gmail.com]
<br>
<b>Sent:</b> Monday, October 2, 2017 8:51 PM<br>
<b>To:</b> Paul Menzel <paulepanter@users.sourceforge.net><br>
<b>Cc:</b> coreboot <coreboot@coreboot.org>; Williams, Hannah <hannah.williams@intel.com><br>
<b>Subject:</b> Re: [coreboot] [RFC] Successful build with GCC 7.2 and IASL 20170831 for coreboot 4.7<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">hi Paul,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I took a look at this, and the error appears to be the result of a change in IASL 20170531: <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><br>
"Improved the behavior of the iASL compiler and disassembler to detect improper use of external declarations"<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">According to the ACPI 6.2 spec, "The External directive informs the ASL compiler that the object is declared external to this table.." This reads to me that if an object is declared External in one table (eg, the DSDT), then its declaration
must be in another table, not in the table in which contains the External reference. As _SB.DPTF.TEVT is declared in the DSDT (in SoC .asl code), then the External declaration in the chromeec/acpi/ec.asl is invalid.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">To test this, I removed the External declaration in ec.asl, and the previously failing boards now build properly with iASL 20170831. I also retested using the current iASL version (20161222), and the aforementioned boards still build correctly.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">If someone wants to corroborate my analysis, then I'm happy to submit a patch to correct the issue<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">cheers,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Matt<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Mon, Oct 2, 2017 at 1:56 AM, Paul Menzel <<a href="mailto:paulepanter@users.sourceforge.net" target="_blank">paulepanter@users.sourceforge.net</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal">Dear coreboot folks,<br>
<br>
<br>
<span class="gmail-">Am Mittwoch, den 20.09.2017, 08:17 +0200 schrieb Paul Menzel:</span><br>
<br>
<span class="gmail-">> I’d like to propose the following goal for the upcoming coreboot 4.7</span><br>
<span class="gmail-">> release.</span><br>
<span class="gmail-">></span><br>
<span class="gmail-">> All boards have to build with GCC 7.2 [1] and IASL 20170831 [2].</span><br>
<span class="gmail-">></span><br>
<span class="gmail-">> For the latter, several Intel boards fail to build [3]. It’d be great</span><br>
<span class="gmail-">> if the maintainers looked into it.</span><br>
<br>
Unfortunately, there was no reply yet. Patrick already blocked the<br>
change-set, and commented that it’ll only go in after the coreboot 4.7<br>
release, which is fine. But the boards should still build in my<br>
opinion.<br>
<br>
The boards below are affected by the IASL update.<br>
<br>
```<br>
$ git grep TEVT<br>
src/ec/google/chromeec/acpi/ec.asl:External (\_SB.DPTF.TEVT, MethodObj)<br>
src/ec/google/chromeec/acpi/ec.asl: If (CondRefOf (\_SB.DPTF.TEVT)) {<br>
src/ec/google/chromeec/acpi/ec.asl: \_SB.DPTF.TEVT (Local0)<br>
src/mainboard/google/cyan/variants/terra/include/variant/acpi/thermal.asl:Method (TEVT, 1, NotSerialized)<br>
src/soc/intel/baytrail/acpi/dptf/thermal.asl:Method (TEVT, 1, NotSerialized)<br>
src/soc/intel/braswell/acpi/dptf/thermal.asl:Method (TEVT, 1, NotSerialized)<br>
src/soc/intel/common/acpi/dptf/thermal.asl:Method (TEVT, 1, NotSerialized)<br>
src/soc/intel/skylake/acpi/dptf/thermal.asl:Method (TEVT, 1, NotSerialized)<br>
```<br>
<br>
What is the process for this? Are the maintainers of the board that<br>
fail to build subscribed on this mailing list?<br>
<br>
<br>
Kind regards,<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
Paul<br>
<br>
<br>
> [1] <a href="https://review.coreboot.org/20809/" target="_blank">https://review.coreboot.org/20809/</a><br>
> [2] <a href="https://review.coreboot.org/21156/" target="_blank">https://review.coreboot.org/21156/</a><br>
> [3] <a href="https://ticket.coreboot.org/issues/138" target="_blank">https://ticket.coreboot.org/issues/138</a><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><br>
--<br>
coreboot mailing list: <a href="mailto:coreboot@coreboot.org">coreboot@coreboot.org</a><br>
<a href="https://mail.coreboot.org/mailman/listinfo/coreboot" target="_blank">https://mail.coreboot.org/mailman/listinfo/coreboot</a><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>