[coreboot] New patch to review for coreboot: d4508c2 Don't include console.h in microcode.c when compiling with ROMCC
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed May 2 01:57:51 CEST 2012
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/988
-gerrit
commit d4508c295915bfad6b19daf4b39a5fa3de631d22
Author: Stefan Reinauer <reinauer at chromium.org>
Date: Tue May 1 16:53:22 2012 -0700
Don't include console.h in microcode.c when compiling with ROMCC
If microcode.c is built by romcc, this indicates that we are running
microcode updates in the bootblock (e.g. before enabling cache as ram).
In this case we did not enable any consoles yet, so we don't output
anything.
This patch removes inclusion of the unnecessary console/console.h for
that case, which was breaking with certain configurations.
Change-Id: Iebb57794d7b1e84cac253d249d47b88de4dd28a3
Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
src/cpu/intel/microcode/microcode.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c
index 1511798..ae1c26a 100644
--- a/src/cpu/intel/microcode/microcode.c
+++ b/src/cpu/intel/microcode/microcode.c
@@ -20,7 +20,9 @@
/* Microcode update for Intel PIII and later CPUs */
#include <stdint.h>
+#if !defined(__ROMCC__)
#include <console/console.h>
+#endif
#include <cpu/cpu.h>
#include <cpu/x86/msr.h>
#include <cpu/intel/microcode.h>
More information about the coreboot
mailing list