[coreboot] [patch] fintek f71859 sio
Uwe Hermann
uwe at hermann-uwe.de
Fri Sep 10 09:26:08 CEST 2010
Hi,
On Thu, Sep 09, 2010 at 09:49:38PM -0600, Marc Jones wrote:
> Index: src/superio/fintek/Kconfig
> ===================================================================
> --- src/superio/fintek/Kconfig (revision 5799)
> +++ src/superio/fintek/Kconfig (working copy)
> @@ -2,3 +2,5 @@
> bool
> config SUPERIO_FINTEK_F71863FG
> bool
> +config SUPERIO_FINTEK_F71859
> + bool
> Index: src/superio/fintek/f71859/f71859_early_serial.c
> ===================================================================
> --- src/superio/fintek/f71859/f71859_early_serial.c (revision 0)
> +++ src/superio/fintek/f71859/f71859_early_serial.c (revision 0)
> @@ -0,0 +1,46 @@
> +/*
> + * This file is part of the coreboot project.
> + *
> + * Copyright (C) 2007 Corey Osgood <corey at slightlyhackish.com>
You can make all those files
* Copyright (C) 2010 Marc Jones <marcj303 at gmail.com>
as each of them is trivial and cannot really be written differently.
> +/* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */
^^^^^^^^^^
F71859
Does your chip have an "F" suffix in the name as the above ones? If yes,
please add it to the name in the code/comments and file/directory names.
> Property changes on: src/superio/fintek/f71859/f71859_early_serial.c
> ___________________________________________________________________
> Added: svn:executable
> + *
Please drop the executable property from all files, it's incorrect and
not needed.
> +/* This chip doesn't have keyboard and mouse support. */
Should probably be dropped unless you are sure the chip doesn't have
keyboard/mouse support.
> +/*
> + * Datasheet:
> +
> + */
Can be dropped.
With the above changes:
Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Uwe.
--
http://hermann-uwe.de | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
More information about the coreboot
mailing list