[coreboot] device_t vs. struct device*
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Mon May 11 16:10:10 CEST 2009
On 11.05.2009 16:04, Myles Watson wrote:
> On Mon, May 11, 2009 at 7:53 AM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>
>
>> Maybe renaming the u32 variants of PCI access functions to *_early or so
>> is one way to proceed.
>>
>
> So to avoid as much confusion as possible, should we use struct device
> * in functions that should never be called early,
Yes please. It helps a lot when reading the code.
> or should we just
> always use device_t because it is shorter and prettier?
>
Please don't. The v3 decision to avoid typedefs helped me a lot when I
was trying to understand the device code.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the coreboot
mailing list