[coreboot] [PATCH] Factor out ROM size calculation from Config.lb
Myles Watson
mylesgw at gmail.com
Tue Apr 21 05:37:29 CEST 2009
> -----Original Message-----
> From: ron minnich [mailto:rminnich at gmail.com]
> On Mon, Apr 20, 2009 at 7:50 PM, ron minnich <rminnich at gmail.com> wrote:
> > the issue is that include files need an end statement. Long story. My
> fault.
>
> that's not quite it either, sorry, it's been a long day.
I think that this small patch fixes it. It seems that | is special to the
tokenizer and needs to be [|], so "||" => "[|][|]". There are no
occurrences of || that I can find in Config.lb files, which probably means
that this bug has stopped people from using it. I made up a test case, but
nothing real. I'd love for someone to think of a place they'd like to use
|| in a Config.lb file and try it out.
Signed-off-by: Myles Watson <mylesgw at gmail.com>
>> +
>> +## This is needed to work around a parser bug.
>> +if USE_FALLBACK_IMAGE
>> +end
>> +
This snippet will also disappear from config/nofailovercalculation.lb with
an ack.
Thanks,
Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_fix.patch
Type: application/octet-stream
Size: 461 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090420/47b7de16/attachment.obj>
More information about the coreboot
mailing list