[coreboot] [PATCH] v3: PIRQ table cosmetics
Uwe Hermann
uwe at hermann-uwe.de
Fri Mar 7 00:31:48 CET 2008
On Wed, Mar 05, 2008 at 02:43:42AM +0100, Carl-Daniel Hailfinger wrote:
> PIRQ table cosmetics/cleanup.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
(but see below)
> Index: LinuxBIOSv3-db800/mainboard/amd/norwich/irq_tables.h
> ===================================================================
> --- LinuxBIOSv3-db800/mainboard/amd/norwich/irq_tables.h (Revision 630)
> +++ LinuxBIOSv3-db800/mainboard/amd/norwich/irq_tables.h (Arbeitskopie)
> @@ -17,17 +17,7 @@
> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include <types.h>
> -#include <lib.h>
> -#include <console.h>
> -#include <device/device.h>
> -#include <device/pci.h>
> -#include <string.h>
> -#include <msr.h>
> -#include <io.h>
> #include <pirq_routing.h>
> -#include <amd_geodelx.h>
> -#include "../../../southbridge/amd/cs5536/cs5536.h"
I assume it's compile-tested that these are not needed?
> /* Number of slots and devices in the PIR table */
> #define SLOT_COUNT 6
> @@ -83,13 +73,19 @@
> {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, /* u8 rfu[11] */
> 0x00, /* Checksum */
> {
> - /* If you change the number of entries, change the IRQ_SLOT_COUNT above! */
> - /* bus, dev|fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */
> - {0x00, (0x01 << 3) | 0x0, {{L_PIRQA, M_PIRQA}, {0x00, 0x00}, {0x00, 0x00}, {0x00, 0x00}}, 0x0, 0x0}, /* cpu */
> - {0x00, (0x0F << 3) | 0x0, {{L_PIRQA, M_PIRQA}, {L_PIRQB, M_PIRQB}, {L_PIRQC, M_PIRQC}, {L_PIRQD, M_PIRQD}}, 0x0, 0x0}, /* chipset */
> - {0x00, (0x0D << 3) | 0x0, {{L_PIRQB, M_PIRQB}, {L_PIRQC, M_PIRQC}, {L_PIRQD, M_PIRQD}, {L_PIRQA, M_PIRQA}}, 0x1, 0x0}, /* slot1 */
> - {0x00, (0x0E << 3) | 0x0, {{L_PIRQC, M_PIRQC}, {L_PIRQD, M_PIRQD}, {L_PIRQA, M_PIRQA}, {L_PIRQB, M_PIRQB}}, 0x2, 0x0}, /* slot2 */
> - {0x00, (0x0B << 3) | 0x0, {{L_PIRQD, M_PIRQD}, {L_PIRQA, M_PIRQA}, {L_PIRQB, M_PIRQB}, {L_PIRQC, M_PIRQC}}, 0x3, 0x0}, /* slot3 */
> - {0x00, (0x0C << 3) | 0x0, {{L_PIRQA, M_PIRQA}, {L_PIRQB, M_PIRQB}, {L_PIRQC, M_PIRQC}, {L_PIRQD, M_PIRQD}}, 0x4, 0x0}, /* slot4 */
> + /* If you change the number of entries, change IRQ_SLOT_COUNT above! */
IRQ_SLOT_COUNT -> SLOT_COUNT
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot
mailing list