[coreboot] [PATCH] v3: remove superfluous #if 1
Stefan Reinauer
stepan at coresystems.de
Thu Feb 14 19:45:09 CET 2008
Carl-Daniel Hailfinger wrote:
> Remove superfluous #if 1. The code has been enabled since it was
> committed, the #if 1 never served any purpose.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>
>
Acked-by: Stefan Reinauer <stepan at coresystems.de>
> Index: LinuxBIOSv3-if0crud/device/pci_device.c
> ===================================================================
> --- LinuxBIOSv3-if0crud/device/pci_device.c (Revision 596)
> +++ LinuxBIOSv3-if0crud/device/pci_device.c (Arbeitskopie)
> @@ -1284,7 +1284,6 @@
> outb((unsigned char)(intBits >> 8), 0x4d1);
>
> /* This seems like an error but is not. */
> -#if 1
> if (inb(0x4d0) != (intBits & 0xff)) {
> printk(BIOS_ERR,
> "%s: lower order bits are wrong: want 0x%x, got 0x%x\n",
> @@ -1295,7 +1294,6 @@
> "%s: lower order bits are wrong: want 0x%x, got 0x%x\n",
> __func__, (intBits >> 8) & 0xff, inb(0x4d1));
> }
> -#endif
> }
>
> /**
>
>
>
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080214/63f4eec8/attachment.sig>
More information about the coreboot
mailing list