[LinuxBIOS] [PATCH] Re: superiotool: conflicting SID for PC97317?

[Ulf Jordan]

On Thu, 6 Dec 2007, bari wrote:

> Ulf Jordan wrote:
>>
>> I'm beginning to suspect that the '371s could be the result of a typo in
>> sensors-detect (introduced in their r2848), that was later carried over to
>> superiotool/nsc.c (r2837).
>>
>
> From the PC97317 data sheet:
> SID Register Index 20h
> The PC97317VUL is identified by the value DFh in this register.
>
> Your part must be a PC97317VUL.
>
> The PC87317VUL is identified by the value D0h in this register.
>
> The PC97371 must be typos.
>
> There was never a PC97371 made by National.
>
> -Bari

Attched is a patch that fixes the typos in superiotool/nsc.c.

/ulf
-------------- next part --------------
Fix typo. According to National's datasheet PC87317 has SID = 0xd0 and
PC97317 has SID = 0xdf. PC87371/PC97371 do not seem to exist.

Signed-off-by: Ulf Jordan <jordan at chalmers.se>

Index: nsc.c
===================================================================
--- nsc.c	(revision 2998)
+++ nsc.c	(working copy)
@@ -25,9 +25,9 @@
 #define CHIP_REV_REG	0x27	/* Super I/O revision ID (SRID) */
 
 static const struct superio_registers reg_table[] = {
-	{0xd0, "PC87371", {	/* From sensors-detect */
+	{0xd0, "PC87317", {
 		{EOT}}},
-	{0xdf, "PC97371", {	/* From sensors-detect */
+	{0xdf, "PC97317", {
 		{EOT}}},
 	{0xe1, "PC87360", {
 		{NOLDN, NULL,