<p>Michał Żygowski has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30358">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/intel/skylake/romstage/romstage_fsp20.c: Add weak CAR pre-console init function<br><br>Add weak funtion before console initialization in romstage to allow mainboards<br>initialize SuperIO for serial console for example.<br><br>Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com><br>Change-Id: I7a44ad626d97adbd20dee5d13325289c23c176ad<br>---<br>M src/soc/intel/skylake/include/fsp20/soc/romstage.h<br>M src/soc/intel/skylake/romstage/romstage_fsp20.c<br>2 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/30358/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/include/fsp20/soc/romstage.h b/src/soc/intel/skylake/include/fsp20/soc/romstage.h</span><br><span>index 364bf52..b7bb604 100644</span><br><span>--- a/src/soc/intel/skylake/include/fsp20/soc/romstage.h</span><br><span>+++ b/src/soc/intel/skylake/include/fsp20/soc/romstage.h</span><br><span>@@ -20,6 +20,7 @@</span><br><span> #include <fsp/api.h></span><br><span> </span><br><span> void mainboard_memory_init_params(FSPM_UPD *mupd);</span><br><span style="color: hsl(120, 100%, 40%);">+void car_mainboard_pre_console_init(void);</span><br><span> void systemagent_early_init(void);</span><br><span> int smbus_read_byte(unsigned int device, unsigned int address);</span><br><span> /* Board type */</span><br><span>diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c</span><br><span>index 2a60158..09af24d 100644</span><br><span>--- a/src/soc/intel/skylake/romstage/romstage_fsp20.c</span><br><span>+++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c</span><br><span>@@ -140,6 +140,7 @@</span><br><span>    uintptr_t top_of_ram;</span><br><span>        struct chipset_power_state *ps;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   car_mainboard_pre_console_init();</span><br><span>    console_init();</span><br><span> </span><br><span>  /* Program MCHBAR, DMIBAR, GDXBAR and EDRAMBAR */</span><br><span>@@ -299,3 +300,8 @@</span><br><span> {</span><br><span>         /* Do nothing */</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+__weak void car_mainboard_pre_console_init(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Do nothing */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>\ No newline at end of file</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30358">change 30358</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30358"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7a44ad626d97adbd20dee5d13325289c23c176ad </div>
<div style="display:none"> Gerrit-Change-Number: 30358 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>