<p><a href="https://review.coreboot.org/c/coreboot/+/30244">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30244/11/src/mainboard/kontron/986lcd-m/romstage.c">File src/mainboard/kontron/986lcd-m/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30244/11/src/mainboard/kontron/986lcd-m/romstage.c@202">Patch Set #11, Line 202:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">        if (read_option(ethernet1, 0) != 0) {<br>         printk(BIOS_DEBUG, "Disabling ethernet adapter 1.\n");<br>              reg32 |= FD_PCIE1;<br>    }<br>     if (read_option(ethernet2, 0) != 0) {<br>         printk(BIOS_DEBUG, "Disabling ethernet adapter 2.\n");<br>              reg32 |= FD_PCIE2;<br>    } else {<br>              if (reg32 & FD_PCIE1)<br>                     port_shuffle = 1;<br>     }<br>     if (read_option(ethernet3, 0) != 0) {<br>         printk(BIOS_DEBUG, "Disabling ethernet adapter 3.\n");<br>              reg32 |= FD_PCIE3;<br>    } else {<br>              if (reg32 & FD_PCIE1)<br>                     port_shuffle = 1;<br>     }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Needs to be ported to ramstage. Or removed? I don't think secunet<br>will ever rebase for this board again. So I wouldn't mind.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30244">change 30244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30244"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I83576599538a02d295fe00b35826f98d8c97d1cf </div>
<div style="display:none"> Gerrit-Change-Number: 30244 </div>
<div style="display:none"> Gerrit-PatchSet: 11 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Damien Zammit <damien@zamaudio.com> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Peter Lemenkov <lemenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Dec 2018 12:10:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>