<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30202">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">northbridge: Remove useless include <device/pci_ids.h><br><br>Change-Id: Ie221a142ed804988a05269d42904aba3ac79e0be<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>Reviewed-on: https://review.coreboot.org/c/30202<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M src/northbridge/amd/amdfam10/get_pci1234.c<br>M src/northbridge/amd/amdht/comlib.c<br>M src/northbridge/amd/amdht/h3finit.c<br>M src/northbridge/amd/amdht/h3ncmn.c<br>M src/northbridge/amd/lx/northbridgeinit.c<br>M src/northbridge/intel/gm45/acpi.c<br>M src/northbridge/intel/gm45/northbridge.c<br>M src/northbridge/intel/haswell/acpi.c<br>M src/northbridge/intel/i945/acpi.c<br>M src/northbridge/intel/nehalem/acpi.c<br>M src/northbridge/intel/pineview/northbridge.c<br>M src/northbridge/intel/sandybridge/acpi.c<br>M src/northbridge/intel/sandybridge/common.c<br>M src/northbridge/intel/x4x/acpi.c<br>M src/northbridge/intel/x4x/northbridge.c<br>15 files changed, 0 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/amd/amdfam10/get_pci1234.c b/src/northbridge/amd/amdfam10/get_pci1234.c</span><br><span>index fee31b6..d9dd2ce 100644</span><br><span>--- a/src/northbridge/amd/amdfam10/get_pci1234.c</span><br><span>+++ b/src/northbridge/amd/amdfam10/get_pci1234.c</span><br><span>@@ -14,7 +14,6 @@</span><br><span>  */</span><br><span> </span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <string.h></span><br><span> #include <stdint.h></span><br><span> </span><br><span>diff --git a/src/northbridge/amd/amdht/comlib.c b/src/northbridge/amd/amdht/comlib.c</span><br><span>index 85cbbc4..7d9a547 100644</span><br><span>--- a/src/northbridge/amd/amdht/comlib.c</span><br><span>+++ b/src/northbridge/amd/amdht/comlib.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <device/pci_def.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> </span><br><span> </span><br><span> /*</span><br><span>diff --git a/src/northbridge/amd/amdht/h3finit.c b/src/northbridge/amd/amdht/h3finit.c</span><br><span>index ee1a4d4..436cb59 100644</span><br><span>--- a/src/northbridge/amd/amdht/h3finit.c</span><br><span>+++ b/src/northbridge/amd/amdht/h3finit.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include <cpu/x86/lapic_def.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <device/pci_def.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <northbridge/amd/amdfam10/raminit.h></span><br><span> #include <northbridge/amd/amdfam10/amdfam10.h></span><br><span> </span><br><span>diff --git a/src/northbridge/amd/amdht/h3ncmn.c b/src/northbridge/amd/amdht/h3ncmn.c</span><br><span>index abb7458..8370b58 100644</span><br><span>--- a/src/northbridge/amd/amdht/h3ncmn.c</span><br><span>+++ b/src/northbridge/amd/amdht/h3ncmn.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <device/pci.h></span><br><span> #include <cpu/amd/msr.h></span><br><span> #include <device/pci_def.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <northbridge/amd/amdfam10/raminit.h></span><br><span> #include <northbridge/amd/amdfam10/amdfam10.h></span><br><span> </span><br><span>diff --git a/src/northbridge/amd/lx/northbridgeinit.c b/src/northbridge/amd/lx/northbridgeinit.c</span><br><span>index c7db156..9655c0e 100644</span><br><span>--- a/src/northbridge/amd/lx/northbridgeinit.c</span><br><span>+++ b/src/northbridge/amd/lx/northbridgeinit.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include "northbridge.h"</span><br><span>diff --git a/src/northbridge/intel/gm45/acpi.c b/src/northbridge/intel/gm45/acpi.c</span><br><span>index 673478c..467c6c1 100644</span><br><span>--- a/src/northbridge/intel/gm45/acpi.c</span><br><span>+++ b/src/northbridge/intel/gm45/acpi.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <arch/acpigen.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "gm45.h"</span><br><span> </span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span>diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c</span><br><span>index a001a67..a04f7f3 100644</span><br><span>--- a/src/northbridge/intel/gm45/northbridge.c</span><br><span>+++ b/src/northbridge/intel/gm45/northbridge.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include <cpu/cpu.h></span><br><span>diff --git a/src/northbridge/intel/haswell/acpi.c b/src/northbridge/intel/haswell/acpi.c</span><br><span>index b3ceed9..a73432a 100644</span><br><span>--- a/src/northbridge/intel/haswell/acpi.c</span><br><span>+++ b/src/northbridge/intel/haswell/acpi.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <arch/acpi.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "haswell.h"</span><br><span> #include <southbridge/intel/lynxpoint/pch.h></span><br><span> </span><br><span>diff --git a/src/northbridge/intel/i945/acpi.c b/src/northbridge/intel/i945/acpi.c</span><br><span>index 0ce7e4b..c36044f 100644</span><br><span>--- a/src/northbridge/intel/i945/acpi.c</span><br><span>+++ b/src/northbridge/intel/i945/acpi.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <arch/acpigen.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "i945.h"</span><br><span> </span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span>diff --git a/src/northbridge/intel/nehalem/acpi.c b/src/northbridge/intel/nehalem/acpi.c</span><br><span>index 7a106c9..08fc09c 100644</span><br><span>--- a/src/northbridge/intel/nehalem/acpi.c</span><br><span>+++ b/src/northbridge/intel/nehalem/acpi.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <types.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "nehalem.h"</span><br><span> </span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span>diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c</span><br><span>index 192c24e..33e8089 100644</span><br><span>--- a/src/northbridge/intel/pineview/northbridge.c</span><br><span>+++ b/src/northbridge/intel/pineview/northbridge.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include <cpu/cpu.h></span><br><span>diff --git a/src/northbridge/intel/sandybridge/acpi.c b/src/northbridge/intel/sandybridge/acpi.c</span><br><span>index 88ac2b1..0a31c85 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/acpi.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/acpi.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <arch/acpi.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "sandybridge.h"</span><br><span> #include <southbridge/intel/bd82x6x/pch.h></span><br><span> </span><br><span>diff --git a/src/northbridge/intel/sandybridge/common.c b/src/northbridge/intel/sandybridge/common.c</span><br><span>index 72b5603..8bfd476 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/common.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/common.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "sandybridge.h"</span><br><span> </span><br><span> enum platform_type get_platform_type(void)</span><br><span>diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c</span><br><span>index 0f235a4..1b016bc 100644</span><br><span>--- a/src/northbridge/intel/x4x/acpi.c</span><br><span>+++ b/src/northbridge/intel/x4x/acpi.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <arch/acpigen.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include "x4x.h"</span><br><span> </span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span>diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c</span><br><span>index d6094ac..af3019c 100644</span><br><span>--- a/src/northbridge/intel/x4x/northbridge.c</span><br><span>+++ b/src/northbridge/intel/x4x/northbridge.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include <cpu/cpu.h></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30202">change 30202</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30202"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie221a142ed804988a05269d42904aba3ac79e0be </div>
<div style="display:none"> Gerrit-Change-Number: 30202 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Damien Zammit <damien@zamaudio.com> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>