<p>Edward Hill has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30304">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Clear SMI_EVENT_STATUS when entering S3/S5<br><br>disable_all_smi_status() was not clearing SMI_EVENT_STATUS. This caused<br>us to complain in the eventlog (ELOG_SLEEP_PENDING_GPE0_WAKE) and then<br>wake early from sleep when waiting for a cr50 reset to turn on a cr50<br>update.<br><br>BUG=b:121203745<br>TEST=Careena remains in S5 until cr50 reset after cr50 update, and<br>ELOG_SLEEP_PENDING_GPE0_WAKE is no longer seen in eventlog.<br><br>Change-Id: I2eec014109249d5c3574c4dbdec5569e2a0bfc8e<br>Signed-off-by: Edward Hill <ecgh@chromium.org><br>---<br>M src/soc/amd/stoneyridge/smihandler.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/30304/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c</span><br><span>index a662bc5d..4854e52 100644</span><br><span>--- a/src/soc/amd/stoneyridge/smihandler.c</span><br><span>+++ b/src/soc/amd/stoneyridge/smihandler.c</span><br><span>@@ -113,6 +113,7 @@</span><br><span> static void disable_all_smi_status(void)</span><br><span> {</span><br><span>  smi_write32(SMI_SCI_STATUS, smi_read32(SMI_SCI_STATUS));</span><br><span style="color: hsl(120, 100%, 40%);">+      smi_write32(SMI_EVENT_STATUS, smi_read32(SMI_EVENT_STATUS));</span><br><span>         smi_write32(SMI_REG_SMISTS0, smi_read32(SMI_REG_SMISTS0));</span><br><span>   smi_write32(SMI_REG_SMISTS1, smi_read32(SMI_REG_SMISTS1));</span><br><span>   smi_write32(SMI_REG_SMISTS2, smi_read32(SMI_REG_SMISTS2));</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30304">change 30304</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30304"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2eec014109249d5c3574c4dbdec5569e2a0bfc8e </div>
<div style="display:none"> Gerrit-Change-Number: 30304 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>