<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30200">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc: Remove useless include <device/pci_ids.h><br><br>Change-Id: Idef8c556ac8c05c5e2047a38629422544392cd62<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>Reviewed-on: https://review.coreboot.org/c/30200<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M src/soc/amd/stoneyridge/include/soc/southbridge.h<br>M src/soc/intel/apollolake/lpc.c<br>M src/soc/intel/baytrail/scc.c<br>M src/soc/intel/baytrail/spi.c<br>M src/soc/intel/braswell/acpi.c<br>M src/soc/intel/braswell/scc.c<br>M src/soc/intel/braswell/spi.c<br>M src/soc/intel/broadwell/me_status.c<br>M src/soc/intel/broadwell/romstage/smbus.c<br>M src/soc/intel/broadwell/romstage/spi.c<br>M src/soc/intel/broadwell/smbus_common.c<br>M src/soc/intel/broadwell/spi.c<br>M src/soc/intel/cannonlake/bootblock/pch.c<br>M src/soc/intel/cannonlake/lpc.c<br>M src/soc/intel/fsp_baytrail/acpi.c<br>M src/soc/intel/fsp_baytrail/include/soc/i2c.h<br>M src/soc/intel/fsp_baytrail/spi.c<br>M src/soc/intel/fsp_broadwell_de/smbus_common.c<br>M src/soc/intel/icelake/bootblock/pch.c<br>M src/soc/intel/icelake/lpc.c<br>M src/soc/intel/quark/i2c.c<br>M src/soc/intel/quark/romstage/pcie.c<br>M src/soc/intel/skylake/lpc.c<br>M src/soc/intel/skylake/me.c<br>24 files changed, 0 insertions(+), 24 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>index 32756cd..88aa7db 100644</span><br><span>--- a/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>+++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>@@ -19,7 +19,6 @@</span><br><span> </span><br><span> #include <arch/io.h></span><br><span> #include <types.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <soc/iomap.h></span><br><span>diff --git a/src/soc/intel/apollolake/lpc.c b/src/soc/intel/apollolake/lpc.c</span><br><span>index 451aa73..a20b82a 100644</span><br><span>--- a/src/soc/intel/apollolake/lpc.c</span><br><span>+++ b/src/soc/intel/apollolake/lpc.c</span><br><span>@@ -16,7 +16,6 @@</span><br><span> </span><br><span> #include <console/console.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <intelblocks/lpc_lib.h></span><br><span> #include <intelblocks/rtc.h></span><br><span> #include <soc/gpio.h></span><br><span>diff --git a/src/soc/intel/baytrail/scc.c b/src/soc/intel/baytrail/scc.c</span><br><span>index 7f97f09..a6b4fe3 100644</span><br><span>--- a/src/soc/intel/baytrail/scc.c</span><br><span>+++ b/src/soc/intel/baytrail/scc.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <reg_script.h></span><br><span> </span><br><span> #include <soc/iosf.h></span><br><span>diff --git a/src/soc/intel/baytrail/spi.c b/src/soc/intel/baytrail/spi.c</span><br><span>index d81b878..d893816 100644</span><br><span>--- a/src/soc/intel/baytrail/spi.c</span><br><span>+++ b/src/soc/intel/baytrail/spi.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <arch/io.h></span><br><span> #include <commonlib/helpers.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <spi_flash.h></span><br><span> #include <spi-generic.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c</span><br><span>index 5c66ea1..efddc3b 100644</span><br><span>--- a/src/soc/intel/braswell/acpi.c</span><br><span>+++ b/src/soc/intel/braswell/acpi.c</span><br><span>@@ -28,7 +28,6 @@</span><br><span> #include <cpu/x86/smm.h></span><br><span> #include <cpu/x86/tsc.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <ec/google/chromeec/ec.h></span><br><span> #include <drivers/intel/gma/opregion.h></span><br><span> #include <rules.h></span><br><span>diff --git a/src/soc/intel/braswell/scc.c b/src/soc/intel/braswell/scc.c</span><br><span>index 17fc685..5c874e1 100644</span><br><span>--- a/src/soc/intel/braswell/scc.c</span><br><span>+++ b/src/soc/intel/braswell/scc.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <soc/iosf.h></span><br><span> #include <soc/nvs.h></span><br><span> #include <soc/ramstage.h></span><br><span>diff --git a/src/soc/intel/braswell/spi.c b/src/soc/intel/braswell/spi.c</span><br><span>index 0f42a90..a5f835d 100644</span><br><span>--- a/src/soc/intel/braswell/spi.c</span><br><span>+++ b/src/soc/intel/braswell/spi.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <commonlib/helpers.h></span><br><span> #include <console/console.h></span><br><span> #include <delay.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <rules.h></span><br><span> #include <soc/lpc.h></span><br><span> #include <soc/pci_devs.h></span><br><span>diff --git a/src/soc/intel/broadwell/me_status.c b/src/soc/intel/broadwell/me_status.c</span><br><span>index 819e94c..3748701 100644</span><br><span>--- a/src/soc/intel/broadwell/me_status.c</span><br><span>+++ b/src/soc/intel/broadwell/me_status.c</span><br><span>@@ -16,7 +16,6 @@</span><br><span> #include <arch/io.h></span><br><span> #include <console/console.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include <soc/pci_devs.h></span><br><span>diff --git a/src/soc/intel/broadwell/romstage/smbus.c b/src/soc/intel/broadwell/romstage/smbus.c</span><br><span>index 3f9dcd0..fd886c4 100644</span><br><span>--- a/src/soc/intel/broadwell/romstage/smbus.c</span><br><span>+++ b/src/soc/intel/broadwell/romstage/smbus.c</span><br><span>@@ -15,7 +15,6 @@</span><br><span>  */</span><br><span> </span><br><span> #include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <reg_script.h></span><br><span> #include <soc/iomap.h></span><br><span>diff --git a/src/soc/intel/broadwell/romstage/spi.c b/src/soc/intel/broadwell/romstage/spi.c</span><br><span>index c4a5452..2fd1fc8 100644</span><br><span>--- a/src/soc/intel/broadwell/romstage/spi.c</span><br><span>+++ b/src/soc/intel/broadwell/romstage/spi.c</span><br><span>@@ -15,7 +15,6 @@</span><br><span> </span><br><span> #include <arch/io.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <delay.h></span><br><span> #include <soc/spi.h></span><br><span>diff --git a/src/soc/intel/broadwell/smbus_common.c b/src/soc/intel/broadwell/smbus_common.c</span><br><span>index bec988f..99ed55b 100644</span><br><span>--- a/src/soc/intel/broadwell/smbus_common.c</span><br><span>+++ b/src/soc/intel/broadwell/smbus_common.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <device/path.h></span><br><span> #include <device/smbus_def.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <soc/ramstage.h></span><br><span> #include <soc/smbus.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/broadwell/spi.c b/src/soc/intel/broadwell/spi.c</span><br><span>index 2b2d603..2317c9a 100644</span><br><span>--- a/src/soc/intel/broadwell/spi.c</span><br><span>+++ b/src/soc/intel/broadwell/spi.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <delay.h></span><br><span> #include <arch/io.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <spi_flash.h></span><br><span> #include <spi-generic.h></span><br><span> #include <soc/pci_devs.h></span><br><span>diff --git a/src/soc/intel/cannonlake/bootblock/pch.c b/src/soc/intel/cannonlake/bootblock/pch.c</span><br><span>index b06c81b..73e159a 100644</span><br><span>--- a/src/soc/intel/cannonlake/bootblock/pch.c</span><br><span>+++ b/src/soc/intel/cannonlake/bootblock/pch.c</span><br><span>@@ -16,7 +16,6 @@</span><br><span> </span><br><span> #include <console/console.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <intelblocks/fast_spi.h></span><br><span> #include <intelblocks/gspi.h></span><br><span> #include <intelblocks/lpc_lib.h></span><br><span>diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c</span><br><span>index 0195cef..c33b3c3 100644</span><br><span>--- a/src/soc/intel/cannonlake/lpc.c</span><br><span>+++ b/src/soc/intel/cannonlake/lpc.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <delay.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <pc80/isa-dma.h></span><br><span> #include <pc80/i8259.h></span><br><span> #include <arch/io.h></span><br><span>diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>index fb14af9..8fcbb52 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <soc/baytrail.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <soc/pci_devs.h></span><br><span> #include <soc/acpi.h></span><br><span> #include <string.h></span><br><span>diff --git a/src/soc/intel/fsp_baytrail/include/soc/i2c.h b/src/soc/intel/fsp_baytrail/include/soc/i2c.h</span><br><span>index 4efb9bd..7ac5f8f 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/include/soc/i2c.h</span><br><span>+++ b/src/soc/intel/fsp_baytrail/include/soc/i2c.h</span><br><span>@@ -18,7 +18,6 @@</span><br><span> </span><br><span> #include <arch/io.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <stdlib.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/fsp_baytrail/spi.c b/src/soc/intel/fsp_baytrail/spi.c</span><br><span>index 26d2281..4537bcc 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/spi.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/spi.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <delay.h></span><br><span> #include <arch/io.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <spi_flash.h></span><br><span> #include <spi-generic.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/fsp_broadwell_de/smbus_common.c b/src/soc/intel/fsp_broadwell_de/smbus_common.c</span><br><span>index 20e8f09..e179b55 100644</span><br><span>--- a/src/soc/intel/fsp_broadwell_de/smbus_common.c</span><br><span>+++ b/src/soc/intel/fsp_broadwell_de/smbus_common.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <device/path.h></span><br><span> #include <device/smbus_def.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <soc/ramstage.h></span><br><span> #include <soc/smbus.h></span><br><span> </span><br><span>diff --git a/src/soc/intel/icelake/bootblock/pch.c b/src/soc/intel/icelake/bootblock/pch.c</span><br><span>index 5268856..28d669a 100644</span><br><span>--- a/src/soc/intel/icelake/bootblock/pch.c</span><br><span>+++ b/src/soc/intel/icelake/bootblock/pch.c</span><br><span>@@ -15,7 +15,6 @@</span><br><span> </span><br><span> #include <console/console.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <intelblocks/fast_spi.h></span><br><span> #include <intelblocks/gspi.h></span><br><span> #include <intelblocks/lpc_lib.h></span><br><span>diff --git a/src/soc/intel/icelake/lpc.c b/src/soc/intel/icelake/lpc.c</span><br><span>index 9bf1b78..422ba1e 100644</span><br><span>--- a/src/soc/intel/icelake/lpc.c</span><br><span>+++ b/src/soc/intel/icelake/lpc.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #include <delay.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <pc80/isa-dma.h></span><br><span> #include <pc80/i8259.h></span><br><span> #include <arch/io.h></span><br><span>diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c</span><br><span>index 2a194af..a3bfb3b 100644</span><br><span>--- a/src/soc/intel/quark/i2c.c</span><br><span>+++ b/src/soc/intel/quark/i2c.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <device/device.h></span><br><span> #include <device/i2c_simple.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <soc/i2c.h></span><br><span> #include <soc/ramstage.h></span><br><span> #include <soc/reg_access.h></span><br><span>diff --git a/src/soc/intel/quark/romstage/pcie.c b/src/soc/intel/quark/romstage/pcie.c</span><br><span>index bdc3902..dc54a32 100644</span><br><span>--- a/src/soc/intel/quark/romstage/pcie.c</span><br><span>+++ b/src/soc/intel/quark/romstage/pcie.c</span><br><span>@@ -15,7 +15,6 @@</span><br><span> </span><br><span> #include <delay.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <soc/pci_devs.h></span><br><span> #include <soc/reg_access.h></span><br><span> #include <soc/romstage.h></span><br><span>diff --git a/src/soc/intel/skylake/lpc.c b/src/soc/intel/skylake/lpc.c</span><br><span>index 73757f2..8d97822 100644</span><br><span>--- a/src/soc/intel/skylake/lpc.c</span><br><span>+++ b/src/soc/intel/skylake/lpc.c</span><br><span>@@ -19,7 +19,6 @@</span><br><span> #include <delay.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <pc80/isa-dma.h></span><br><span> #include <pc80/i8259.h></span><br><span> #include <arch/io.h></span><br><span>diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c</span><br><span>index 6baa568..64a94ab 100644</span><br><span>--- a/src/soc/intel/skylake/me.c</span><br><span>+++ b/src/soc/intel/skylake/me.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #include <commonlib/helpers.h></span><br><span> #include <console/console.h></span><br><span> #include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ids.h></span><br><span> #include <intelblocks/cse.h></span><br><span> #include <soc/iomap.h></span><br><span> #include <soc/me.h></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30200">change 30200</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30200"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idef8c556ac8c05c5e2047a38629422544392cd62 </div>
<div style="display:none"> Gerrit-Change-Number: 30200 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: York Yang <york.yang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>